From: Flavio Leitner <fbl@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev <netdev@vger.kernel.org>, Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
Leonardo Chiquitto <lchiquitto@suse.com>,
Jiri Pirko <jpirko@redhat.com>
Subject: Re: [net-next] bonding: don't allow the master to become its slave
Date: Thu, 9 Aug 2012 16:39:06 -0300 [thread overview]
Message-ID: <20120809163906.6dc0b6d4@obelix.rh> (raw)
In-Reply-To: <1344539003.2593.7.camel@bwh-desktop.uk.solarflarecom.com>
On Thu, 9 Aug 2012 20:03:23 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Thu, 2012-08-09 at 15:30 -0300, Flavio Leitner wrote:
> > It doesn't make any sense to allow the master to become
> > its slave. That creates a loop of events causing a crash.
>
> What if there are other intermediate devices, e.g. the slave is a VLAN
> sub-device of the bond? And doesn't team also have this problem?
>
> I think a more general check for such loops might be required.
Maybe patching netdev_set_master() to fail in the loop case is
the way to go. That would work for bonding, team and bridge.
What you think?
fbl
next prev parent reply other threads:[~2012-08-09 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 18:30 [net-next] bonding: don't allow the master to become its slave Flavio Leitner
2012-08-09 18:45 ` Leonardo Chiquitto
2012-08-09 19:03 ` Ben Hutchings
2012-08-09 19:23 ` Jay Vosburgh
2012-08-09 19:39 ` Flavio Leitner [this message]
2012-08-09 19:55 ` Jiri Pirko
2012-08-09 20:52 ` Flavio Leitner
2012-08-09 21:09 ` Ben Hutchings
2012-08-09 21:27 ` Jay Vosburgh
2012-08-09 23:43 ` David Miller
2012-08-10 13:04 ` Jiri Pirko
2012-08-09 19:54 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809163906.6dc0b6d4@obelix.rh \
--to=fbl@redhat.com \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=fubar@us.ibm.com \
--cc=jpirko@redhat.com \
--cc=lchiquitto@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.