From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/3] perf tools: Initial bash completion support
Date: Thu, 9 Aug 2012 16:08:19 -0300 [thread overview]
Message-ID: <20120809190819.GD4084@infradead.org> (raw)
In-Reply-To: <20120809192706.625671f0@pyramind.ukuu.org.uk>
Em Thu, Aug 09, 2012 at 07:27:06PM +0100, Alan Cox escreveu:
> > > 3rd patch should fix this.
> >
> > Huh? The problem is not /etc/bash_completion.d/ not existing, it exists,
> > its just that I'm not using sudo nor installing as root, this new bash
> > completion file is the only one that is being installed on the root
> > filesystem, all others are in ~acme/
>
> And even with permissions it might not have the right security labels on
> a well secured box.
>
> It's a neat little script (or once its been properly security audited
> will be) but IMHO it belongs in the distro bash script packages.
Yeah, I think we can keep it in the kernel sources and then send new
versions to the bash-completion-devel@lists.alioth.debian.org guys.
To test I just did:
ln -s ~/etc/bash_completion.d/perf ~/.bash_completion
Frédéric, I merged your patches as-is and pushed them to my perf/core
branch, thanks!
- Arnaldo
next prev parent reply other threads:[~2012-08-09 19:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 14:31 [PATCH 0/3] perf tools: Basic bash completion support v3 Frederic Weisbecker
2012-08-09 14:31 ` [PATCH 1/3] perf tools: Initial bash completion support Frederic Weisbecker
2012-08-09 16:35 ` Arnaldo Carvalho de Melo
2012-08-09 16:40 ` David Ahern
2012-08-09 17:14 ` Arnaldo Carvalho de Melo
2012-08-09 17:24 ` David Ahern
2012-08-09 17:31 ` Frederic Weisbecker
2012-08-09 18:27 ` Alan Cox
2012-08-09 19:08 ` Arnaldo Carvalho de Melo [this message]
2012-08-10 13:30 ` Frederic Weisbecker
2012-08-09 17:00 ` Frederic Weisbecker
2012-08-09 17:11 ` Arnaldo Carvalho de Melo
2012-08-09 17:13 ` Frederic Weisbecker
2012-08-21 15:38 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2012-08-09 14:31 ` [PATCH 2/3] perf tools: Support for events bash completion Frederic Weisbecker
2012-08-21 15:39 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
2012-08-09 14:31 ` [PATCH 3/3] perf tools: Fix /etc config related installation Frederic Weisbecker
2012-08-21 15:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809190819.GD4084@infradead.org \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.