All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 0/5] Port of MUSB gadget driver from Linux
Date: Thu, 9 Aug 2012 21:15:16 +0200	[thread overview]
Message-ID: <201208092115.16264.marek.vasut@gmail.com> (raw)
In-Reply-To: <1344460381-22362-1-git-send-email-ilya.yanok@cogentembedded.com>

Dear Ilya Yanok,

> Current MUSB driver in U-Boot uses old UDC API while new gagdet
> client drivers need new gadget API. Also current MUSB driver has
> some significant limitations (like inability to handle tx for
> endpoints other than ep0). So I think port of new Linux driver is
> desirable.
> 
> This is initial port, performed mostly by putting DM, host and OTG
> code under #ifndef __UBOOT__ clauses. My intention was to be as
> close as possible to the original to ease of possible resyncs.
> Some warnings are suppressed via CFLAGS. There are some style
> problems but I'm not touching them for now for the above mentioned
> reason. There is obviously some room for optimisation, some
> structure fields are unused as well as (probably) some code.
> 
> This is not a replacement for existing MUSB driver (at least for
> now), cause host mode is not supported and there are still consumers
> of the old interface.
> 
> Host mode, OTG and DMA are not supported. The only ported driver
> is for TI AM33xx, but others should be easy to port too.
> 
> Tested it on AM335x EVM and BeagleBone with CDC Ethernet gadget.

I hate to say it ... but given that this will cause duplication of code, I'm 
somehow inclined to push you to do a complete replacement of the old musb code, 
remove it and add this.

Tom, what do you think?

> Ilya Yanok (5):
>   linux/usb/ch9.h: update with the version from Linux tree
>   musb-new: port of Linux musb gadget driver
>   musb-new: dsps backend driver
>   am33xx: init OTG hardware and new musb gadget driver
>   am335x_evm: enable musb gadget on port 0

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-08-09 19:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08 21:12 [U-Boot] [RFC PATCH 0/5] Port of MUSB gadget driver from Linux Ilya Yanok
2012-08-08 21:12 ` [U-Boot] [RFC PATCH 1/5] linux/usb/ch9.h: update with the version from Linux tree Ilya Yanok
2012-08-08 21:12 ` [U-Boot] [RFC PATCH 2/5] musb-new: port of Linux musb gadget driver Ilya Yanok
2012-08-08 21:12 ` [U-Boot] [RFC PATCH 3/5] musb-new: dsps backend driver Ilya Yanok
2012-08-08 21:13 ` [U-Boot] [RFC PATCH 4/5] am33xx: init OTG hardware and new musb gadget driver Ilya Yanok
2012-08-08 21:13 ` [U-Boot] [RFC PATCH 5/5] am335x_evm: enable musb gadget on port 0 Ilya Yanok
2012-08-09 19:15 ` Marek Vasut [this message]
2012-08-09 19:23   ` [U-Boot] [RFC PATCH 0/5] Port of MUSB gadget driver from Linux Wolfgang Denk
2012-08-10 17:56     ` Ilya Yanok
2012-08-10 18:58       ` Ilya Yanok
2012-08-10 18:59         ` Ilya Yanok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208092115.16264.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.