Re: Kernel crashes when CONFIG_MTD_NAND_VERIFY_WRITE=y

[Marek Vasut <marex@denx.de>]

Dear Marek Vasut,

> Dear Fabio Estevam,
> 
> > Hi Marek,
> > 
> > On Thu, Aug 9, 2012 at 8:53 PM, Marek Vasut <marex@denx.de> wrote:
> > > This problem is there because the GPMI NAND code doesn't implement
> > > verify buffer
> > 
> > > function and defaults to nand_verify_buf() call in nand_base.c:
> > Yes, you are right.
> > 
> > > Now the chip->IO_ADDR_R is zero, making the kernel access bogus
> > > location, and therefore crash. So the correct solution is to properly
> > > implement the struct nand_chip *'s verify_buf function.
> > 
> > Right, the patch below prevents the kernel to happen:
> > 
> > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > @@ -857,6 +857,15 @@ static uint8_t gpmi_read_byte(struct mtd_info *mtd)
> > 
> >         return buf[0];
> >  
> >  }
> > 
> > +/* Used by the upper layer to verify the data in NAND Flash
> > + * with the data in the buf. */
> > +static int gpmi_verify_buf(struct mtd_info *mtd,
> > +                               const u_char *buf, int len)
> > +{
> > +       /* TODO: implement verify_buf mechanism */
> > +       return 0;
> > +}
> 
> NAK! This is only a workaround, proper implementation is needed. If it's
> not implemented now, I'm pretty sure such workaround will be there
> forever.
[...]

btw if you want a workaround, make Kconfig entry so it'd disallow VERIFY to be 
selected for GPMI_NAND, but that's also a wrong way to go.

Best regards,
Marek Vasut