From: Thierry Reding <thierry.reding@avionic-design.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 2/2] pwm: core: Fix coding style issues
Date: Fri, 10 Aug 2012 12:02:33 +0200 [thread overview]
Message-ID: <20120810100233.GA1503@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <CAK9yfHwmfW9K9jBfJJXr5S1nJOsetedkEQ96Rh4DT_zvOGr4eQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On Fri, Aug 10, 2012 at 03:29:08PM +0530, Sachin Kamat wrote:
> On 10 August 2012 15:25, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > On Fri, Aug 10, 2012 at 10:12:10AM +0530, Sachin Kamat wrote:
> >> Fixes the following:
> >> WARNING: line over 80 characters
> >> ERROR: spaces required around that ':' (ctx:VxW)
> >> WARNING: Prefer pr_warn(... to pr_warning(...
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> ---
> >> drivers/pwm/core.c | 6 +++---
> >> 1 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> >> index efc20f8..929be13 100644
> >> --- a/drivers/pwm/core.c
> >> +++ b/drivers/pwm/core.c
> >> @@ -130,7 +130,7 @@ static int pwm_device_request(struct pwm_device *pwm, const char *label)
> >> }
> >>
> >> static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc,
> >> - const struct of_phandle_args *args)
> >> + const struct of_phandle_args *args)
> >> {
> >> struct pwm_device *pwm;
> >>
> >
> > Can this hunk be removed, please? I think aligning the arguments is more
> > useful than respecting the 80-columns limit.
>
> Sure, if you think so. Anyway it was just one space deleted. Do you
> want me to re-send the patch?
No, with your permission, I'll just leave that hunk out and remove the
"WARNING: line over 80 characters" line from the commit message.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-10 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 4:42 [PATCH 1/2] pwm: vt8500: Fix coding style issue Sachin Kamat
2012-08-10 4:42 ` [PATCH 2/2] pwm: core: Fix coding style issues Sachin Kamat
2012-08-10 9:55 ` Thierry Reding
2012-08-10 9:59 ` Sachin Kamat
2012-08-10 10:02 ` Thierry Reding [this message]
2012-08-10 10:04 ` Sachin Kamat
2012-08-10 10:51 ` Joe Perches
2012-08-10 10:58 ` Thierry Reding
2012-08-10 11:02 ` Sachin Kamat
2012-08-10 11:37 ` [PATCH 1/2] pwm: vt8500: Fix coding style issue Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810100233.GA1503@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.