From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jianpeng Ma" Subject: [RFC PATCH] fs/direct-io.c: Add REQ_NOIDLE for last bio . Date: Fri, 10 Aug 2012 20:37:14 +0800 Message-ID: <201208102037120467864@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Cc: linux-fsdevel , linux-kernel To: viro Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Rm9yIGxhc3QgYmlvIG9mIGRpbywgdGhlcmUgYXJlIG5vIGJpbyB3aWxsIGNvbWUuU28gc2V0IFJF UV9OT0lETEUuDQoNClNpZ25lZC1vZmYtYnk6IEppYW5wZW5nIE1hIDxtYWppYW5wZW5nQGdtYWls LmNvbT4NCi0tLQ0KIGZzL2RpcmVjdC1pby5jIHwgICAxNSArKysrKysrKysrKystLS0NCiAxIGZp bGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdp dCBhL2ZzL2RpcmVjdC1pby5jIGIvZnMvZGlyZWN0LWlvLmMNCmluZGV4IDFmYWY0Y2IuLjdjNjk1 OGYgMTAwNjQ0DQotLS0gYS9mcy9kaXJlY3QtaW8uYw0KKysrIGIvZnMvZGlyZWN0LWlvLmMNCkBA IC0xMjcsNiArMTI3LDcgQEAgc3RydWN0IGRpbyB7DQogCWludCBwYWdlX2Vycm9yczsJCS8qIGVy cm5vIGZyb20gZ2V0X3VzZXJfcGFnZXMoKSAqLw0KIAlpbnQgaXNfYXN5bmM7CQkJLyogaXMgSU8g YXN5bmMgPyAqLw0KIAlpbnQgaW9fZXJyb3I7CQkJLyogSU8gZXJyb3IgaW4gY29tcGxldGlvbiBw YXRoICovDQorCXNlY3Rvcl90IGVuZF9zZWN0b3I7CQkvKiB0aGUgbGFzdCBzZWN0b3IgZm9yIHRo aXMgZGlvICovDQogCXVuc2lnbmVkIGxvbmcgcmVmY291bnQ7CQkvKiBkaXJlY3RfaW9fd29ya2Vy KCkgYW5kIGJpb3MgKi8NCiAJc3RydWN0IGJpbyAqYmlvX2xpc3Q7CQkvKiBzaW5nbHkgbGlua2Vk IHZpYSBiaV9wcml2YXRlICovDQogCXN0cnVjdCB0YXNrX3N0cnVjdCAqd2FpdGVyOwkvKiB3YWl0 aW5nIHRhc2sgKE5VTEwgaWYgbm9uZSkgKi8NCkBAIC0zNjksMjEgKzM3MCwyOCBAQCBzdGF0aWMg aW5saW5lIHZvaWQgZGlvX2Jpb19zdWJtaXQoc3RydWN0IGRpbyAqZGlvLCBzdHJ1Y3QgZGlvX3N1 Ym1pdCAqc2RpbykNCiB7DQogCXN0cnVjdCBiaW8gKmJpbyA9IHNkaW8tPmJpbzsNCiAJdW5zaWdu ZWQgbG9uZyBmbGFnczsNCi0NCisJaW50IHJ3ID0gZGlvLT5ydzsNCiAJYmlvLT5iaV9wcml2YXRl ID0gZGlvOw0KIA0KIAlzcGluX2xvY2tfaXJxc2F2ZSgmZGlvLT5iaW9fbG9jaywgZmxhZ3MpOw0K IAlkaW8tPnJlZmNvdW50Kys7DQogCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRpby0+YmlvX2xv Y2ssIGZsYWdzKTsNCiANCisJLyoNCisJICogSWYgYmlvIGlzIHRoZSBsYXN0IGZvciBkaW8sc28g bm8gYmlvIGNhbiBhcnJpdmUgZm9yIGxvdy1sZXZlbA0KKwkgKiB1bmxlc3MgdGhpcyBkaW8gY29t cGxldGVkLg0KKwkgKi8NCisJaWYgKGJpby0+Ymlfc2VjdG9yICsgYmlvX3NlY3RvcnMoYmlvKSA+ PSBkaW8tPmVuZF9zZWN0b3IpDQorCQlydyB8PSBSRVFfTk9JRExFOw0KKw0KIAlpZiAoZGlvLT5p c19hc3luYyAmJiBkaW8tPnJ3ID09IFJFQUQpDQogCQliaW9fc2V0X3BhZ2VzX2RpcnR5KGJpbyk7 DQogDQogCWlmIChzZGlvLT5zdWJtaXRfaW8pDQotCQlzZGlvLT5zdWJtaXRfaW8oZGlvLT5ydywg YmlvLCBkaW8tPmlub2RlLA0KKwkJc2Rpby0+c3VibWl0X2lvKHJ3LCBiaW8sIGRpby0+aW5vZGUs DQogCQkJICAgICAgIHNkaW8tPmxvZ2ljYWxfb2Zmc2V0X2luX2Jpbyk7DQogCWVsc2UNCi0JCXN1 Ym1pdF9iaW8oZGlvLT5ydywgYmlvKTsNCisJCXN1Ym1pdF9iaW8ocncsIGJpbyk7DQogDQogCXNk aW8tPmJpbyA9IE5VTEw7DQogCXNkaW8tPmJvdW5kYXJ5ID0gMDsNCkBAIC0xMTQ3LDYgKzExNTUs NyBAQCBkb19ibG9ja2Rldl9kaXJlY3RfSU8oaW50IHJ3LCBzdHJ1Y3Qga2lvY2IgKmlvY2IsIHN0 cnVjdCBpbm9kZSAqaW5vZGUsDQogDQogCWRpby0+aW5vZGUgPSBpbm9kZTsNCiAJZGlvLT5ydyA9 IHJ3Ow0KKwlkaW8tPmVuZF9zZWN0b3IgPSBlbmQgPj4gOTsNCiAJc2Rpby5ibGtiaXRzID0gYmxr Yml0czsNCiAJc2Rpby5ibGtmYWN0b3IgPSBpbm9kZS0+aV9ibGtiaXRzIC0gYmxrYml0czsNCiAJ c2Rpby5ibG9ja19pbl9maWxlID0gb2Zmc2V0ID4+IGJsa2JpdHM7DQotLSANCjEuNy45LjUNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755451Ab2HJMg6 (ORCPT ); Fri, 10 Aug 2012 08:36:58 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:53250 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396Ab2HJMg4 (ORCPT ); Fri, 10 Aug 2012 08:36:56 -0400 Date: Fri, 10 Aug 2012 20:37:14 +0800 From: "Jianpeng Ma" To: viro Cc: linux-fsdevel , linux-kernel Subject: [RFC PATCH] fs/direct-io.c: Add REQ_NOIDLE for last bio . X-Priority: 3 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.91[en] Mime-Version: 1.0 Message-ID: <201208102037120467864@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id q7ACb5Rw032544 For last bio of dio, there are no bio will come.So set REQ_NOIDLE. Signed-off-by: Jianpeng Ma --- fs/direct-io.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/fs/direct-io.c b/fs/direct-io.c index 1faf4cb..7c6958f 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -127,6 +127,7 @@ struct dio { int page_errors; /* errno from get_user_pages() */ int is_async; /* is IO async ? */ int io_error; /* IO error in completion path */ + sector_t end_sector; /* the last sector for this dio */ unsigned long refcount; /* direct_io_worker() and bios */ struct bio *bio_list; /* singly linked via bi_private */ struct task_struct *waiter; /* waiting task (NULL if none) */ @@ -369,21 +370,28 @@ static inline void dio_bio_submit(struct dio *dio, struct dio_submit *sdio) { struct bio *bio = sdio->bio; unsigned long flags; - + int rw = dio->rw; bio->bi_private = dio; spin_lock_irqsave(&dio->bio_lock, flags); dio->refcount++; spin_unlock_irqrestore(&dio->bio_lock, flags); + /* + * If bio is the last for dio,so no bio can arrive for low-level + * unless this dio completed. + */ + if (bio->bi_sector + bio_sectors(bio) >= dio->end_sector) + rw |= REQ_NOIDLE; + if (dio->is_async && dio->rw == READ) bio_set_pages_dirty(bio); if (sdio->submit_io) - sdio->submit_io(dio->rw, bio, dio->inode, + sdio->submit_io(rw, bio, dio->inode, sdio->logical_offset_in_bio); else - submit_bio(dio->rw, bio); + submit_bio(rw, bio); sdio->bio = NULL; sdio->boundary = 0; @@ -1147,6 +1155,7 @@ do_blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, dio->inode = inode; dio->rw = rw; + dio->end_sector = end >> 9; sdio.blkbits = blkbits; sdio.blkfactor = inode->i_blkbits - blkbits; sdio.block_in_file = offset >> blkbits; -- 1.7.9.5 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I