All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] COMMON: Use __stringify() instead of MK_STR()
Date: Fri, 10 Aug 2012 23:17:34 +0200	[thread overview]
Message-ID: <20120810231734.4d7cad23@wker> (raw)
In-Reply-To: <1344423139-18610-3-git-send-email-marex@denx.de>

Hi Marek,

On Wed,  8 Aug 2012 12:52:19 +0200
Marek Vasut <marex@denx.de> wrote:
...
> diff --git a/common/env_common.c b/common/env_common.c
> index d9e990d..39e1792 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -37,8 +37,6 @@ DECLARE_GLOBAL_DATA_PTR;
>  /************************************************************************
>   * Default settings to be used when no valid environment is found
>   */
> -#define XMK_STR(x)	#x
> -#define MK_STR(x)	XMK_STR(x)

including linux/stringify.h here is needed. It doesn't build
otherwise, since this file doesn't include common.h:
...
Configuring for actux1_4_16 - Board: actux1, Options: FLASH2X2
/home/ag/git/u-boot/common/env_embedded.c:110:15: error: expected ?}? before ?__stringify?
make[1]: *** [env_embedded.o] Error 1
make: *** [tools] Error 2
arm-linux-gnueabi-size: './u-boot': No such file
/home/ag/git/u-boot/common/env_embedded.c:110:15: error: expected ?}? before ?__stringify?
make[1]: *** [env_embedded.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** wait: No child processes.  Stop.
make: *** [tools] Error 2

Please fix. Thanks!

Anatolij

  parent reply	other threads:[~2012-08-10 21:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08 10:52 [U-Boot] [PATCH 1/3] COMMON: Add __stringify() function Marek Vasut
2012-08-08 10:52 ` [U-Boot] [PATCH 2/3] COMMON: Use __stringify() instead of xstr() Marek Vasut
2012-08-08 15:18   ` Mike Frysinger
2012-08-10 20:22   ` Anatolij Gustschin
2012-08-08 10:52 ` [U-Boot] [PATCH 3/3] COMMON: Use __stringify() instead of MK_STR() Marek Vasut
2012-08-08 15:17   ` Mike Frysinger
2012-08-10 20:26   ` Anatolij Gustschin
2012-08-10 21:17   ` Anatolij Gustschin [this message]
2012-08-10 21:20     ` Marek Vasut
2012-08-08 15:16 ` [U-Boot] [PATCH 1/3] COMMON: Add __stringify() function Mike Frysinger
2012-08-08 15:21 ` Mike Frysinger
2012-08-08 16:01   ` Marek Vasut
2012-08-09  2:08     ` Mike Frysinger
2012-08-10 20:21 ` Anatolij Gustschin
2012-08-10 20:45   ` Wolfgang Denk
2012-08-10 20:52     ` Marek Vasut
2012-08-10 21:20     ` Anatolij Gustschin
2012-08-10 21:23       ` Marek Vasut
2012-08-10 20:51 ` [U-Boot] [PATCH 1/3 V2] " Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120810231734.4d7cad23@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.