From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] Add env var giving the board revision
Date: Sat, 11 Aug 2012 13:48:33 -0400 [thread overview]
Message-ID: <201208111348.33937.vapier@gentoo.org> (raw)
In-Reply-To: <2028294275.2280404.1344620768178.JavaMail.root@advansee.com>
On Friday 10 August 2012 13:46:08 Beno?t Th?baudeau wrote:
> The board revision can be a useful env var, like its serial number.
unless i missed something, there is no standard "rev" variable today, which
means this change can easily break anyone who happens to already be using a
variable named "rev".
i also don't see value here in hardcoding another variable that:
- no one is setting
- is way too generic (rev of *what* ? cpu ? board ? u-boot ?
something else ?)
- adds nothing on top of the existing "serial#"
so NAK from me
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120811/60097306/attachment.pgp>
next prev parent reply other threads:[~2012-08-11 17:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:44 [U-Boot] [PATCH 0/5] Cleanup and extend env vars Benoît Thébaudeau
2012-08-10 17:45 ` [U-Boot] [PATCH 1/5] fw_env: Add env vars describing U-Boot target board Benoît Thébaudeau
2012-09-18 19:04 ` [U-Boot] [U-Boot, " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 2/5] env_common: Add missing ethprime Benoît Thébaudeau
2012-09-18 19:05 ` [U-Boot] [U-Boot,2/5] " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 3/5] env import/export: Remove from help if disabled Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-09-18 19:05 ` [U-Boot] [U-Boot, " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 4/5] README: The ver env var is not read-only Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-08-11 18:07 ` Benoît Thébaudeau
2012-08-12 11:54 ` Wolfgang Denk
2012-08-12 13:58 ` Benoît Thébaudeau
2012-08-12 14:49 ` Mike Frysinger
2012-08-13 13:01 ` [U-Boot] [PATCH] README: Update ver env var description Benoît Thébaudeau
2012-08-17 4:20 ` Mike Frysinger
2012-09-02 16:56 ` Wolfgang Denk
2012-08-12 11:49 ` [U-Boot] [PATCH 4/5] README: The ver env var is not read-only Wolfgang Denk
2012-08-10 17:46 ` [U-Boot] [PATCH 5/5] Add env var giving the board revision Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger [this message]
2012-08-11 19:11 ` Benoît Thébaudeau
2012-08-12 11:58 ` Wolfgang Denk
2012-08-12 14:02 ` Benoît Thébaudeau
2012-08-12 14:09 ` Benoît Thébaudeau
2012-08-12 21:06 ` Wolfgang Denk
2012-08-12 21:21 ` Jeroen Hofstee
2012-08-12 14:54 ` Mike Frysinger
2012-08-12 17:11 ` Benoît Thébaudeau
2012-08-12 21:20 ` Wolfgang Denk
2012-08-12 21:35 ` Benoît Thébaudeau
2012-08-13 9:59 ` Wolfgang Denk
2012-08-13 0:28 ` Mike Frysinger
2012-08-12 21:05 ` Wolfgang Denk
2012-08-12 11:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208111348.33937.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.