From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 11 Aug 2012 16:15:16 -0400 Subject: [U-Boot] [PATCH] mtest: Disable dcache during test In-Reply-To: <1565957817.2304803.1344715536780.JavaMail.root@advansee.com> References: <1565957817.2304803.1344715536780.JavaMail.root@advansee.com> Message-ID: <201208111615.17567.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 11 August 2012 16:05:36 Beno?t Th?baudeau wrote: > On 08/11/2012 21:47, Andrew Dyer wrote: > > I agree with Mike, use the current dcache settings. U-boot has always > > assumed the user knew what they were doing. > > If you want to print a small message with the dcache setting that > > makes sense to me, but no big warning. > > Then, something like the following at runtime in the first lines printed my > mtest? > > dcache state: on i'd be fine with that. something like below (if you want to test & post, that'd be good). -mike diff --git a/common/cmd_mem.c b/common/cmd_mem.c index 18f0a3f..5628f6a 100644 --- a/common/cmd_mem.c +++ b/common/cmd_mem.c @@ -651,8 +651,10 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) else iteration_limit = 0; + printf("Testing %08x ... %08x (dcache: %s):\n", (uint)start, (uint)end, + dcache_status() ? "on" : "off"); + #if defined(CONFIG_SYS_ALT_MEMTEST) - printf ("Testing %08x ... %08x:\n", (uint)start, (uint)end); debug("%s:%d: start 0x%p end 0x%p\n", __FUNCTION__, __LINE__, start, end); -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: