From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] USB: Fix strict aliasing in ohci-hcd
Date: Sun, 12 Aug 2012 02:07:30 +0200 [thread overview]
Message-ID: <201208120207.31009.marex@denx.de> (raw)
In-Reply-To: <1344721749-25644-1-git-send-email-troy.kisky@boundarydevices.com>
Dear Troy Kisky,
> commit 5f6aa03fda2a0a79940765865c1e4266be8a75f8
> USB: Fix complaints about strict aliasing in OHCI-HCD
>
> tried to fix this, but gcc4.4 still complains. So, this
> patch basically reverts the above and does a simpler fix.
>
> also, the above commit incorrectly changed
> /* corresponds to data_buf[4-7] */
> datab [1] = 0;
> to
>
> /* corresponds to databuf.u8[4-7] */
> databuf.u8[1] = 0;
>
> This patch also fixes that.
[...]
AGAIN?! :-C
If I were to run git log on that file, I'd get like five such "fixes" :-(
I'll review this properly tomorrow, this will be certainly a very pleasant
reviewing time ;-)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-12 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 21:49 [U-Boot] [PATCH 1/1] USB: Fix strict aliasing in ohci-hcd Troy Kisky
2012-08-12 0:07 ` Marek Vasut [this message]
2012-08-14 17:33 ` Marek Vasut
2012-08-14 18:47 ` Troy Kisky
2012-08-14 19:12 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208120207.31009.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.