From: Sean Young <sean@mess.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
linux-media@vger.kernel.org, lirc-list@lists.sourceforge.net
Subject: Re: [PATCH] [media] iguanair: various fixes
Date: Sun, 12 Aug 2012 19:32:21 +0100 [thread overview]
Message-ID: <20120812183221.GA26171@pequod.mess.org> (raw)
In-Reply-To: <5026FA51.9080600@redhat.com>
On Sat, Aug 11, 2012 at 09:35:29PM -0300, Mauro Carvalho Chehab wrote:
> Em 31-07-2012 07:37, Sean Young escreveu:
> > This fixes:
> > - rx_overflow while holding down any down button on a nec remote
> > - suspend/resume
> > - stop receiver on rmmod
> > - advertise rx_resolution and timeout properly
> > - code simplify
> > - ignore unsupported firmware versions
>
> Please don't mix several different things on the same patch; it makes
> harder for review and, if any of these changes break, a git revert would
> change a lot of unrelated things. It also makes hard for bug disect.
That makes a lot of sense. I'll rework the patch.
> Tip: "git citool" helps a lot to break messy patches into smaller, concise
> ones.
Thank you very much, I'll try that.
Sean
prev parent reply other threads:[~2012-08-12 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 10:37 [PATCH] [media] iguanair: various fixes Sean Young
2012-08-12 0:35 ` Mauro Carvalho Chehab
2012-08-12 18:32 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120812183221.GA26171@pequod.mess.org \
--to=sean@mess.org \
--cc=jarod@wilsonet.com \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.