From: Theodore Ts'o <tytso@mit.edu>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Realign trace events structs to make it smaller
Date: Sun, 12 Aug 2012 22:29:44 -0400 [thread overview]
Message-ID: <20120813022944.GC13080@thunk.org> (raw)
In-Reply-To: <1342631254-23891-1-git-send-email-anatol.pomozov@gmail.com>
On Wed, Jul 18, 2012 at 10:07:33AM -0700, Anatol Pomozov wrote:
> Most hardware architectures require that data (including struct fields)
> have to be aligned in memory. To make it happen compiler inserts padding
> between struct fields if they are not aligned correctly.
>
> Reorder fields to remove paddings and make structures denser. Making data
> smaller saves some memory that is very important for trace events.
> Tracing buffer has limited size and making objects smaller we can put more
> of them without overflowing the tracing buffer.
>
> To find data struct holes I used 'pahole -H 1 -E -I vmlinux.o' from
> 'dwarves' package.
>
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2012-08-13 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 17:07 [PATCH 1/2] ext4: Realign trace events structs to make it smaller Anatol Pomozov
2012-07-18 17:07 ` [PATCH 2/2] ext4: Add missing space to trace message Anatol Pomozov
2012-08-13 2:29 ` Theodore Ts'o
2012-08-13 2:29 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813022944.GC13080@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=anatol.pomozov@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.