All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Andrey Wagin <avagin@gmail.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 2/3] perf: teach perf inject to merge sched_stat_* and sched_switch events
Date: Mon, 13 Aug 2012 11:17:43 +0200	[thread overview]
Message-ID: <20120813091743.GC3471@gmail.com> (raw)
In-Reply-To: <20120806233146.GK21441@infradead.org>


* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> static int process_sample_event(struct perf_tool *tool __used,
>  				union perf_event *event,
>  				struct perf_sample *sample,
>				struct perf_evsel *evsel,
>  				struct machine *machine)

Just saw this 5-parameter function signature fly by: as a 
separate clean-up it would be really neat to stick most of these 
into an intuitively named helper structure or so. 

struct event_context ectx?

That would make extension of the context easier as well in the 
future. Or so.

Thanks,

	Ingo

  reply	other threads:[~2012-08-13  9:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 10:01 [PATCH 0/3] perf: Teach perf tool to profile sleep times Andrew Vagin
2012-08-06 10:01 ` [PATCH 1/3] perf: teach "perf inject" to work with files Andrew Vagin
2012-08-06 18:12   ` Arnaldo Carvalho de Melo
2012-08-06 10:01 ` [PATCH 2/3] perf: teach perf inject to merge sched_stat_* and sched_switch events Andrew Vagin
2012-08-06 18:19   ` Arnaldo Carvalho de Melo
2012-08-06 19:43     ` Andrey Wagin
2012-08-06 22:00       ` Arnaldo Carvalho de Melo
2012-08-06 23:31         ` Arnaldo Carvalho de Melo
2012-08-13  9:17           ` Ingo Molnar [this message]
2012-08-06 10:01 ` [PATCH 3/3] perf: mark a dso if it's used Andrew Vagin
2012-08-06 18:14   ` Arnaldo Carvalho de Melo
2012-08-06 19:50     ` Andrey Wagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120813091743.GC3471@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=avagin@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.