From: Theodore Ts'o <tytso@mit.edu>
To: Zach Brown <zab@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Zheng Liu <wenqing.lz@taobao.com>,
Eric Sandeen <sandeen@redhat.com>,
Zheng Liu <gnehzuil.liu@gmail.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH v2] ext4: dynamical adjust the length of zero-out chunk
Date: Mon, 13 Aug 2012 14:40:53 -0400 [thread overview]
Message-ID: <20120813184053.GE32484@thunk.org> (raw)
In-Reply-To: <20120813173224.GF9117@lenny.home.zabbo.net>
On Mon, Aug 13, 2012 at 10:32:24AM -0700, Zach Brown wrote:
> > we allow it to be tunable via sysfs and set an initial default value
> > of 32, so instead of creating uninitalized extents smaller than
>
> s/32/16/?
Oops, nice catch.
> It'd be nice to define the tunable in terms of some fixed unit, kb or
> mb, whatever, and then translate to the block size in the code so people
> don't have to do that math by hand.
>
> No?
Agreed, thanks for the suggestion. The next question is whether the
default maximum zero-out size should be 256k (as previously
documented) or 128k (as previously coded).
The previously rule of thumb which I had used was that after doing a
random seek, the time needed to write 4k and 32k was pretty much in
the noise. But that was a number from several years ago. I suppose I
should do some quick experiments to see what is a good number these
days....
- Ted
next prev parent reply other threads:[~2012-08-13 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 6:48 [PATCH v2] ext4: dynamical adjust the length of zero-out chunk Zheng Liu
2012-07-12 14:49 ` Eric Sandeen
2012-07-12 16:51 ` Andreas Dilger
2012-07-17 7:55 ` Zheng Liu
2012-08-13 3:22 ` Theodore Ts'o
2012-08-13 6:55 ` Zheng Liu
2012-08-13 17:32 ` Zach Brown
2012-08-13 18:40 ` Theodore Ts'o [this message]
2012-08-13 19:49 ` Zach Brown
2012-08-13 21:35 ` Theodore Ts'o
2012-08-14 15:13 ` [PATCH] ext4: make the zero-out chunk size tunable Theodore Ts'o
2012-08-14 15:15 ` [PATCH -v4] " Theodore Ts'o
2012-07-17 7:19 ` [PATCH v2] ext4: dynamical adjust the length of zero-out chunk Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813184053.GE32484@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=wenqing.lz@taobao.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.