From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 14/15] qom: object_unref call reclaimer Date: Mon, 13 Aug 2012 15:56:10 -0300 Message-ID: <20120813185610.GF25268@amt.cnet> References: <1344407156-25562-1-git-send-email-qemulist@gmail.com> <1344407156-25562-15-git-send-email-qemulist@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Jan Kiszka , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= To: Liu Ping Fan Return-path: Content-Disposition: inline In-Reply-To: <1344407156-25562-15-git-send-email-qemulist@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Wed, Aug 08, 2012 at 02:25:55PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > iohandler/bh/timer may use DeviceState when its refcnt=0, > postpone the reclaimer till they have done with it. > > Signed-off-by: Liu Ping Fan > --- > qom/object.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 822bdb7..1452b1b 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -23,6 +23,8 @@ > #include "qbool.h" > #include "qint.h" > #include "qstring.h" > +#include "hw/qdev.h" > +#include "qemu/reclaimer.h" > > #define MAX_INTERFACES 32 > > @@ -646,7 +648,12 @@ void object_unref(Object *obj) > { > g_assert(atomic_read(&obj->ref) > 0); > if (atomic_dec_and_test(&obj->ref)) { > - object_finalize(obj); > + /* fixme, maybe introduce obj->finalze to make this more elegant */ > + if (object_dynamic_cast(obj, TYPE_DEVICE) != NULL) { > + qemu_reclaimer_enqueue(obj, object_finalize); > + } else { > + object_finalize(obj); > + } > } As mentioned, removal under the original plan is combination of per-device lock and object reference. An initial step is parallel mmio only, with everything else under the big lock. Again, _only_ parallel mmio lookup as a first target is a good goal, IMO. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0zow-0003XA-F3 for qemu-devel@nongnu.org; Mon, 13 Aug 2012 14:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0zos-0004qX-QD for qemu-devel@nongnu.org; Mon, 13 Aug 2012 14:56:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0zos-0004q9-I0 for qemu-devel@nongnu.org; Mon, 13 Aug 2012 14:56:54 -0400 Date: Mon, 13 Aug 2012 15:56:10 -0300 From: Marcelo Tosatti Message-ID: <20120813185610.GF25268@amt.cnet> References: <1344407156-25562-1-git-send-email-qemulist@gmail.com> <1344407156-25562-15-git-send-email-qemulist@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1344407156-25562-15-git-send-email-qemulist@gmail.com> Subject: Re: [Qemu-devel] [PATCH 14/15] qom: object_unref call reclaimer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: kvm@vger.kernel.org, Jan Kiszka , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Wed, Aug 08, 2012 at 02:25:55PM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > iohandler/bh/timer may use DeviceState when its refcnt=0, > postpone the reclaimer till they have done with it. > > Signed-off-by: Liu Ping Fan > --- > qom/object.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 822bdb7..1452b1b 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -23,6 +23,8 @@ > #include "qbool.h" > #include "qint.h" > #include "qstring.h" > +#include "hw/qdev.h" > +#include "qemu/reclaimer.h" > > #define MAX_INTERFACES 32 > > @@ -646,7 +648,12 @@ void object_unref(Object *obj) > { > g_assert(atomic_read(&obj->ref) > 0); > if (atomic_dec_and_test(&obj->ref)) { > - object_finalize(obj); > + /* fixme, maybe introduce obj->finalze to make this more elegant */ > + if (object_dynamic_cast(obj, TYPE_DEVICE) != NULL) { > + qemu_reclaimer_enqueue(obj, object_finalize); > + } else { > + object_finalize(obj); > + } > } As mentioned, removal under the original plan is combination of per-device lock and object reference. An initial step is parallel mmio only, with everything else under the big lock. Again, _only_ parallel mmio lookup as a first target is a good goal, IMO.