From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 0/2] Document pagetable_reserve PVOP and enforce a better semantic Date: Mon, 13 Aug 2012 16:42:18 -0400 Message-ID: <20120813204218.GB12550@phenom.dumpdata.com> References: <1344608227-30910-1-git-send-email-attilio.rao@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1344608227-30910-1-git-send-email-attilio.rao@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Attilio Rao Cc: Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, Aug 10, 2012 at 03:17:05PM +0100, Attilio Rao wrote: > When looking for documenting the pagetable_reserve PVOP, I realized that it > assumes start == pgt_buf_start. I think this is not semantically right > (even if with the current code this should not be a problem in practice) and > what we really want is to extend the logic in order to do the RO -> RW > convertion also for the range [pgt_buf_start, start). > This patch then implements this missing conversion, adding some smaller > cleanups and finally provides documentation for the PVOP. > Please look at 2/2 for more details on how the comment is structured. > If we get this right we will have a reference to be used later on for others > PVOPs. > A preliminary version of this patch has been already reviewed by > Stefano Stabellini. > > Attilio Rao (2): > XEN, X86: Improve semantic support for pagetable_reserve PVOP > Document the semantic of the pagetable_reserve PVOP The titles need a prefix, like 'x86' or 'xen/x86'. s/PVOP/PVOPS/ > > arch/x86/include/asm/x86_init.h | 19 +++++++++++++++++-- > arch/x86/mm/init.c | 4 ++++ > arch/x86/xen/mmu.c | 22 ++++++++++++++++++++-- > 3 files changed, 41 insertions(+), 4 deletions(-) > > -- > 1.7.2.5