All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/3] mxs: Convert sys_proto.h prefixes to 'mxs'
Date: Mon, 13 Aug 2012 20:59:44 +0200	[thread overview]
Message-ID: <201208132059.44448.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKoWXnM=b=GzbwFH15r4bC7P-0x80oUnSmN2FnGfnE4Bbw@mail.gmail.com>

Dear Otavio Salvador,

> On Mon, Aug 13, 2012 at 3:11 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> > [...]
> > 
> >> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> >> b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c index 84d4a17..ddafddb 100644
> >> --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> >> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> >> @@ -82,9 +82,9 @@ uint8_t mxs_get_bootmode_index(void)
> >> 
> >>       bootmode |= (gpio_get_value(MX28_PAD_LCD_D04__GPIO_1_4) ? 1 : 0)
> >>       << 4; bootmode |= (gpio_get_value(MX28_PAD_LCD_D05__GPIO_1_5) ? 1
> >>       : 0) << 5;
> >> 
> >> -     for (i = 0; i < ARRAY_SIZE(mx28_boot_modes); i++) {
> >> -             masked = bootmode & mx28_boot_modes[i].boot_mask;
> >> -             if (masked == mx28_boot_modes[i].boot_pads)
> >> +     for (i = 0; i < ARRAY_SIZE(mxs_boot_modes); i++) {
> >> +             masked = bootmode & mxs_boot_modes[i].boot_mask;
> >> +             if (masked == mxs_boot_modes[i].boot_pads)
> > 
> > mxs_boot_modes? They're different for mx23 and mx28!
> 
> Yes, they're but the structure is the same so we can use same symbol
> and have a different mxs_boot_modes matrix for each.

Unless we want a single image for mx233 and mx28. Oh well ... for now

Acked-by: Marek Vasut <marex@denx.de>

> >>                       break;
> >>       
> >>       }
> > 
> > [...]
> > 
> > Rest seems fine
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

  reply	other threads:[~2012-08-13 18:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 13:12 [U-Boot] [PATCH v1 1/3] mxs: Remove unused iomux-mx28.h Otavio Salvador
2012-08-13 13:12 ` [U-Boot] [PATCH v1 2/3] mxs: rename regs-clkctrl.h to regs-clkctrl-mx28.h Otavio Salvador
2012-08-13 18:09   ` Marek Vasut
2012-08-13 13:12 ` [U-Boot] [PATCH v1 3/3] mxs: Convert sys_proto.h prefixes to 'mxs' Otavio Salvador
2012-08-13 18:11   ` Marek Vasut
2012-08-13 18:55     ` Otavio Salvador
2012-08-13 18:59       ` Marek Vasut [this message]
2012-08-13 19:02         ` Otavio Salvador
2012-08-13 18:07 ` [U-Boot] [PATCH v1 1/3] mxs: Remove unused iomux-mx28.h Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208132059.44448.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.