From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Devendra Naga <develkernel412222@gmail.com>
Cc: "Javier Muñoz" <jmunhoz@igalia.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Devendra Naga" <devendra.aaru@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info
Date: Mon, 13 Aug 2012 19:30:02 -0700 [thread overview]
Message-ID: <20120814023002.GA1046@kroah.com> (raw)
In-Reply-To: <1344101120-22866-1-git-send-email-develkernel412222@gmail.com>
On Sat, Aug 04, 2012 at 11:10:20PM +0545, Devendra Naga wrote:
> as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
> sm7xxx_probe is not having any assignment, and which leads to copying of the garbage value
> into the id field of the fix struct of fb interface struct. fix it by copying the name before
> calling alloc_fbinfo.
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
> ---
>
> Changes since V1:
> Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1.
Huh? Please resend the correct patch you want me to apply, I'm confused
here.
greg k-h
prev parent reply other threads:[~2012-08-14 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 17:25 [PATCH V2] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info Devendra Naga
2012-08-14 2:30 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814023002.GA1046@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=develkernel412222@gmail.com \
--cc=devendra.aaru@gmail.com \
--cc=jmunhoz@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.