From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 14 Aug 2012 08:27:10 +0200 Subject: [U-Boot] [PATCH] mtest: Disable dcache during test In-Reply-To: <201208111615.17567.vapier@gentoo.org> References: <1565957817.2304803.1344715536780.JavaMail.root@advansee.com> <201208111615.17567.vapier@gentoo.org> Message-ID: <20120814082710.4f867663@aari01-12> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mike, On Sat, 11 Aug 2012 16:15:16 -0400, Mike Frysinger wrote: > On Saturday 11 August 2012 16:05:36 Beno?t Th?baudeau wrote: > > On 08/11/2012 21:47, Andrew Dyer wrote: > > > I agree with Mike, use the current dcache settings. U-boot has > > > always assumed the user knew what they were doing. > > > If you want to print a small message with the dcache setting that > > > makes sense to me, but no big warning. > > > > Then, something like the following at runtime in the first lines > > printed my mtest? > > > > dcache state: on > > i'd be fine with that. something like below (if you want to test & > post, that'd be good). > -mike I'd disagree with this solution; one can easily overlook casual test messages like these. To me it is better that the person doing mtest not trust the cache state at all and check / set it. Amicalement, -- Albert.