From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe002.messaging.microsoft.com [216.32.181.182]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8755C2C0092 for ; Tue, 14 Aug 2012 19:59:07 +1000 (EST) Received: from mail166-ch1 (localhost [127.0.0.1]) by mail166-ch1-R.bigfish.com (Postfix) with ESMTP id 6C0AC6051C for ; Tue, 14 Aug 2012 09:59:02 +0000 (UTC) Received: from CH1EHSMHS021.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.250]) by mail166-ch1.bigfish.com (Postfix) with ESMTP id 83590240087 for ; Tue, 14 Aug 2012 09:59:00 +0000 (UTC) Received: from localhost.localdomain ([10.213.130.145]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id q7E9wuZW020328 for ; Tue, 14 Aug 2012 02:58:57 -0700 Date: Tue, 14 Aug 2012 17:58:59 +0800 From: Zhao Chenhui To: Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source Message-ID: <20120814095859.GA21028@localhost.localdomain> References: <1344329006-10645-1-git-send-email-chenhui.zhao@freescale.com> <1344329006-10645-2-git-send-email-chenhui.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: Sender: Cc: Li Yang-R58472 , Zhao Chenhui-B35336 , B04825@freescale.com, "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote: > On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui wrote: > > > + return -EINVAL; > > + > > + prop = of_get_property(clk_np, "fsl,pmcdr-mask", NULL); > > + if (!prop) { > > + ret = -EINVAL; > > + goto out; > > + } > > + pmcdr_mask = be32_to_cpup(prop); > > + > > + if (enable) > > + /* clear to enable clock in low power mode */ > > + clrbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + else > > + setbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + > > +out: > > + of_node_put(clk_np); > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(mpc85xx_pmc_set_wake); > > Use EXPORT_SYMBOL, not EXPORT_SYMBOL_GPL. > Hi kumar, Is that ok with upstream? -Chenhui From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755621Ab2HNJ7E (ORCPT ); Tue, 14 Aug 2012 05:59:04 -0400 Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:56858 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394Ab2HNJ7D (ORCPT ); Tue, 14 Aug 2012 05:59:03 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(zz98dI9371I1432Izz1202hzz8275bhz2dh2a8h668h839h944hd25hf0ah107ah) Date: Tue, 14 Aug 2012 17:58:59 +0800 From: Zhao Chenhui To: CC: Zhao Chenhui-B35336 , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Li Yang-R58472 , , Subject: Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source Message-ID: <20120814095859.GA21028@localhost.localdomain> References: <1344329006-10645-1-git-send-email-chenhui.zhao@freescale.com> <1344329006-10645-2-git-send-email-chenhui.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote: > On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui wrote: > > > + return -EINVAL; > > + > > + prop = of_get_property(clk_np, "fsl,pmcdr-mask", NULL); > > + if (!prop) { > > + ret = -EINVAL; > > + goto out; > > + } > > + pmcdr_mask = be32_to_cpup(prop); > > + > > + if (enable) > > + /* clear to enable clock in low power mode */ > > + clrbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + else > > + setbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + > > +out: > > + of_node_put(clk_np); > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(mpc85xx_pmc_set_wake); > > Use EXPORT_SYMBOL, not EXPORT_SYMBOL_GPL. > Hi kumar, Is that ok with upstream? -Chenhui