diff for duplicates of <20120814151616.GO4177@suse.de> diff --git a/a/1.txt b/N1/1.txt index 56dc708..6defbfa 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,13 +18,13 @@ already. > free_pages() time. This is done by the invocation of > __free_accounted_pages() and free_accounted_pages(). > -> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> -> CC: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> -> CC: Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org> -> CC: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org> -> CC: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> -> CC: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> -> CC: Suleiman Souhlal <suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> +> Signed-off-by: Glauber Costa <glommer@parallels.com> +> CC: Christoph Lameter <cl@linux.com> +> CC: Pekka Enberg <penberg@cs.helsinki.fi> +> CC: Michal Hocko <mhocko@suse.cz> +> CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> +> CC: Johannes Weiner <hannes@cmpxchg.org> +> CC: Suleiman Souhlal <suleiman@google.com> > --- > include/linux/gfp.h | 3 +++ > mm/page_alloc.c | 38 ++++++++++++++++++++++++++++++++++++++ @@ -112,7 +112,7 @@ As this thing is called from within the allocator, it's not clear why __memcg_kmem_new_page is exported. I can't imagine why a module would call it directly although maybe you cover that somewhere else in the series. -From the point of view of a hook, that is acceptable but just barely. I have +>From the point of view of a hook, that is acceptable but just barely. I have slammed other hooks because it was possible for a subsystem to override them meaning the runtime cost could be anything. I did not spot a similar issue here but if I missed it, it's still unacceptable. At least here the cost @@ -196,3 +196,9 @@ Again, this is a fairly heavy operation. -- Mel Gorman SUSE Labs + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index bb6444b..022d646 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,23 +1,22 @@ "ref\01344517279-30646-1-git-send-email-glommer@parallels.com\0" "ref\01344517279-30646-8-git-send-email-glommer@parallels.com\0" - "ref\01344517279-30646-8-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org\0" - "From\0Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>\0" + "From\0Mel Gorman <mgorman@suse.de>\0" "Subject\0Re: [PATCH v2 07/11] mm: Allocate kernel pages to the right memcg\0" "Date\0Tue, 14 Aug 2012 16:16:16 +0100\0" - "To\0Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>\0" - "Cc\0linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org - cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org - Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org> - Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> - Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> - kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org - Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> - David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> - Pekka Enberg <penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> - Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org> - " Suleiman Souhlal <suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\0" + "To\0Glauber Costa <glommer@parallels.com>\0" + "Cc\0linux-kernel@vger.kernel.org" + linux-mm@kvack.org + cgroups@vger.kernel.org + devel@openvz.org + Michal Hocko <mhocko@suse.cz> + Johannes Weiner <hannes@cmpxchg.org> + Andrew Morton <akpm@linux-foundation.org> + kamezawa.hiroyu@jp.fujitsu.com + Christoph Lameter <cl@linux.com> + David Rientjes <rientjes@google.com> + Pekka Enberg <penberg@kernel.org> + Pekka Enberg <penberg@cs.helsinki.fi> + " Suleiman Souhlal <suleiman@google.com>\0" "\00:1\0" "b\0" "On Thu, Aug 09, 2012 at 05:01:15PM +0400, Glauber Costa wrote:\n" @@ -40,13 +39,13 @@ "> free_pages() time. This is done by the invocation of\n" "> __free_accounted_pages() and free_accounted_pages().\n" "> \n" - "> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>\n" - "> CC: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>\n" - "> CC: Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org>\n" - "> CC: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>\n" - "> CC: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>\n" - "> CC: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>\n" - "> CC: Suleiman Souhlal <suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\n" + "> Signed-off-by: Glauber Costa <glommer@parallels.com>\n" + "> CC: Christoph Lameter <cl@linux.com>\n" + "> CC: Pekka Enberg <penberg@cs.helsinki.fi>\n" + "> CC: Michal Hocko <mhocko@suse.cz>\n" + "> CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>\n" + "> CC: Johannes Weiner <hannes@cmpxchg.org>\n" + "> CC: Suleiman Souhlal <suleiman@google.com>\n" "> ---\n" "> include/linux/gfp.h | 3 +++\n" "> mm/page_alloc.c | 38 ++++++++++++++++++++++++++++++++++++++\n" @@ -134,7 +133,7 @@ "__memcg_kmem_new_page is exported. I can't imagine why a module would call\n" "it directly although maybe you cover that somewhere else in the series.\n" "\n" - "From the point of view of a hook, that is acceptable but just barely. I have\n" + ">From the point of view of a hook, that is acceptable but just barely. I have\n" "slammed other hooks because it was possible for a subsystem to override them\n" "meaning the runtime cost could be anything. I did not spot a similar issue\n" "here but if I missed it, it's still unacceptable. At least here the cost\n" @@ -217,6 +216,12 @@ "\n" "-- \n" "Mel Gorman\n" - SUSE Labs + "SUSE Labs\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -64c1d2e6a8a047e70efac79f2ab03ba043b1e992587d251b55c86644ef6932eb +570079fafed47aa82e4d3cfc3bd1afd681b5fa78586e61685a8de5209edc51eb
diff --git a/a/1.txt b/N2/1.txt index 56dc708..f8cf71c 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -18,13 +18,13 @@ already. > free_pages() time. This is done by the invocation of > __free_accounted_pages() and free_accounted_pages(). > -> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> -> CC: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> -> CC: Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org> -> CC: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org> -> CC: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> -> CC: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> -> CC: Suleiman Souhlal <suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> +> Signed-off-by: Glauber Costa <glommer@parallels.com> +> CC: Christoph Lameter <cl@linux.com> +> CC: Pekka Enberg <penberg@cs.helsinki.fi> +> CC: Michal Hocko <mhocko@suse.cz> +> CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> +> CC: Johannes Weiner <hannes@cmpxchg.org> +> CC: Suleiman Souhlal <suleiman@google.com> > --- > include/linux/gfp.h | 3 +++ > mm/page_alloc.c | 38 ++++++++++++++++++++++++++++++++++++++ @@ -112,7 +112,7 @@ As this thing is called from within the allocator, it's not clear why __memcg_kmem_new_page is exported. I can't imagine why a module would call it directly although maybe you cover that somewhere else in the series. -From the point of view of a hook, that is acceptable but just barely. I have +>From the point of view of a hook, that is acceptable but just barely. I have slammed other hooks because it was possible for a subsystem to override them meaning the runtime cost could be anything. I did not spot a similar issue here but if I missed it, it's still unacceptable. At least here the cost diff --git a/a/content_digest b/N2/content_digest index bb6444b..fbdafee 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,22 @@ "ref\01344517279-30646-1-git-send-email-glommer@parallels.com\0" "ref\01344517279-30646-8-git-send-email-glommer@parallels.com\0" - "ref\01344517279-30646-8-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org\0" - "From\0Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>\0" + "From\0Mel Gorman <mgorman@suse.de>\0" "Subject\0Re: [PATCH v2 07/11] mm: Allocate kernel pages to the right memcg\0" "Date\0Tue, 14 Aug 2012 16:16:16 +0100\0" - "To\0Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>\0" - "Cc\0linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org - cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org - Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org> - Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> - Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> - kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org - Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> - David Rientjes <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> - Pekka Enberg <penberg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> - Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org> - " Suleiman Souhlal <suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\0" + "To\0Glauber Costa <glommer@parallels.com>\0" + "Cc\0linux-kernel@vger.kernel.org" + linux-mm@kvack.org + cgroups@vger.kernel.org + devel@openvz.org + Michal Hocko <mhocko@suse.cz> + Johannes Weiner <hannes@cmpxchg.org> + Andrew Morton <akpm@linux-foundation.org> + kamezawa.hiroyu@jp.fujitsu.com + Christoph Lameter <cl@linux.com> + David Rientjes <rientjes@google.com> + Pekka Enberg <penberg@kernel.org> + Pekka Enberg <penberg@cs.helsinki.fi> + " Suleiman Souhlal <suleiman@google.com>\0" "\00:1\0" "b\0" "On Thu, Aug 09, 2012 at 05:01:15PM +0400, Glauber Costa wrote:\n" @@ -40,13 +39,13 @@ "> free_pages() time. This is done by the invocation of\n" "> __free_accounted_pages() and free_accounted_pages().\n" "> \n" - "> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>\n" - "> CC: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>\n" - "> CC: Pekka Enberg <penberg-bbCR+/B0CizivPeTLB3BmA@public.gmane.org>\n" - "> CC: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>\n" - "> CC: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>\n" - "> CC: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>\n" - "> CC: Suleiman Souhlal <suleiman-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>\n" + "> Signed-off-by: Glauber Costa <glommer@parallels.com>\n" + "> CC: Christoph Lameter <cl@linux.com>\n" + "> CC: Pekka Enberg <penberg@cs.helsinki.fi>\n" + "> CC: Michal Hocko <mhocko@suse.cz>\n" + "> CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>\n" + "> CC: Johannes Weiner <hannes@cmpxchg.org>\n" + "> CC: Suleiman Souhlal <suleiman@google.com>\n" "> ---\n" "> include/linux/gfp.h | 3 +++\n" "> mm/page_alloc.c | 38 ++++++++++++++++++++++++++++++++++++++\n" @@ -134,7 +133,7 @@ "__memcg_kmem_new_page is exported. I can't imagine why a module would call\n" "it directly although maybe you cover that somewhere else in the series.\n" "\n" - "From the point of view of a hook, that is acceptable but just barely. I have\n" + ">From the point of view of a hook, that is acceptable but just barely. I have\n" "slammed other hooks because it was possible for a subsystem to override them\n" "meaning the runtime cost could be anything. I did not spot a similar issue\n" "here but if I missed it, it's still unacceptable. At least here the cost\n" @@ -219,4 +218,4 @@ "Mel Gorman\n" SUSE Labs -64c1d2e6a8a047e70efac79f2ab03ba043b1e992587d251b55c86644ef6932eb +9397d87ee797bea46476e646e1378f789fe3f89aea1547a3b06045204707eaf6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.