From: Andrew Morton <akpm@linux-foundation.org>
To: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: <a.zummo@towertech.it>, <sameo@linux.intel.com>,
<broonie@opensource.wolfsonmicro.com>, <ldewangan@nvidia.com>,
<kyle.manna@fuel7.com>, <rtc-linux@googlegroups.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC
Date: Tue, 14 Aug 2012 16:52:11 -0700 [thread overview]
Message-ID: <20120814165211.daf24c81.akpm@linux-foundation.org> (raw)
In-Reply-To: <1343284519-30505-1-git-send-email-vbyravarasu@nvidia.com>
On Thu, 26 Jul 2012 12:05:19 +0530
Venu Byravarasu <vbyravarasu@nvidia.com> wrote:
> TPS65910 PMIC is a MFD with RTC as one of the device.
> Adding RTC driver for supporting RTC device present
> inside TPS65910 PMIC.
>
> Only support for RTC alarm is implemented as part of this patch.
It needs a build fix:
drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_suspend':
drivers/rtc/rtc-tps65910.c:313: error: request for member 'irqstat' in something not a structure or union
drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_resume':
drivers/rtc/rtc-tps65910.c:327: error: request for member 'irqstat' in something not a structure or union
--- a/drivers/rtc/rtc-tps65910.c~rtc-tps65910-add-rtc-driver-for-tps65910-pmic-rtc-fix
+++ a/drivers/rtc/rtc-tps65910.c
@@ -310,7 +310,7 @@ static int tps65910_rtc_suspend(struct p
/* Store current list of enabled interrupts*/
ret = regmap_read(tps->regmap, TPS65910_RTC_INTERRUPTS,
- &tps->rtc.irqstat);
+ &tps->rtc->irqstat);
if (ret < 0)
return ret;
@@ -324,7 +324,7 @@ static int tps65910_rtc_resume(struct pl
/* Restore list of enabled interrupts before suspend */
return regmap_write(tps->regmap, TPS65910_RTC_INTERRUPTS,
- tps->rtc.irqstat);
+ tps->rtc->irqstat);
}
static const struct dev_pm_ops tps65910_rtc_pm_ops = {
but it still has problems:
drivers/rtc/rtc-tps65910.c:331: warning: initialization from incompatible pointer type
drivers/rtc/rtc-tps65910.c:332: warning: initialization from incompatible pointer type
fix and resend, please?
next prev parent reply other threads:[~2012-08-14 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 6:35 [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC Venu Byravarasu
2012-07-27 13:28 ` Samuel Ortiz
2012-07-30 9:16 ` Stephen Boyd
2012-07-30 10:07 ` Venu Byravarasu
2012-07-30 17:06 ` Stephen Boyd
2012-08-14 23:52 ` Andrew Morton [this message]
2012-08-16 5:48 ` Venu Byravarasu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814165211.daf24c81.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyle.manna@fuel7.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.