* [U-Boot] [PATCH] COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake
@ 2012-08-14 19:27 Marek Vasut
2012-08-14 19:50 ` Daniel Schwierzeck
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2012-08-14 19:27 UTC (permalink / raw)
To: u-boot
The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated
" y" instead of "y", causing the vendor lib not being built. This
in turn made some spear boards and nvidia boards broken.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 5ce5cc3..947f3ff 100644
--- a/Makefile
+++ b/Makefile
@@ -225,7 +225,7 @@ endif
OBJS := $(addprefix $(obj),$(OBJS))
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n)
+HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
LIBS-y += lib/libgeneric.o
LIBS-y += lib/lzma/liblzma.o
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake
2012-08-14 19:27 [U-Boot] [PATCH] COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake Marek Vasut
@ 2012-08-14 19:50 ` Daniel Schwierzeck
2012-08-14 20:23 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Schwierzeck @ 2012-08-14 19:50 UTC (permalink / raw)
To: u-boot
Hi Marek,
2012/8/14 Marek Vasut <marex@denx.de>:
> The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated
> " y" instead of "y", causing the vendor lib not being built. This
> in turn made some spear boards and nvidia boards broken.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 5ce5cc3..947f3ff 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -225,7 +225,7 @@ endif
>
> OBJS := $(addprefix $(obj),$(OBJS))
>
> -HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n)
> +HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
>
> LIBS-y += lib/libgeneric.o
> LIBS-y += lib/lzma/liblzma.o
> --
> 1.7.10.4
>
there is already a patch for this
http://patchwork.ozlabs.org/patch/177235/
sorry for the inconvenience
--
Best regards,
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake
2012-08-14 19:50 ` Daniel Schwierzeck
@ 2012-08-14 20:23 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2012-08-14 20:23 UTC (permalink / raw)
To: u-boot
Dear Daniel Schwierzeck,
> Hi Marek,
>
> 2012/8/14 Marek Vasut <marex@denx.de>:
> > The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated
> > " y" instead of "y", causing the vendor lib not being built. This
> > in turn made some spear boards and nvidia boards broken.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
[..]
> there is already a patch for this
> http://patchwork.ozlabs.org/patch/177235/
>
> sorry for the inconvenience
That's ok, don't sweat it :)
Your patch is better, thanks Dan!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-14 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-14 19:27 [U-Boot] [PATCH] COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake Marek Vasut
2012-08-14 19:50 ` Daniel Schwierzeck
2012-08-14 20:23 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.