From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, gleb@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCHv2] kvm: drop parameter validation
Date: Tue, 14 Aug 2012 22:35:35 -0300 [thread overview]
Message-ID: <20120815013535.GA14033@amt.cnet> (raw)
In-Reply-To: <20120814162028.GA27670@redhat.com>
On Tue, Aug 14, 2012 at 07:20:28PM +0300, Michael S. Tsirkin wrote:
> We validate irq pin number when routing is setup, so
> code handling illegal irq # in pic and ioapic on each injection
> is never called.
> Drop it, replace with BUG_ON to catch out of bounds access bugs.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> add BUG_ON at Gleb's suggestion
>
> arch/x86/kvm/i8259.c | 18 +++++++++---------
> virt/kvm/ioapic.c | 37 +++++++++++++++++++------------------
> 2 files changed, 28 insertions(+), 27 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2012-08-15 1:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 16:20 [PATCHv2] kvm: drop parameter validation Michael S. Tsirkin
2012-08-15 1:35 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815013535.GA14033@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.