From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/2] s390: Always use "long" for ssize_t to match size_t
Date: Wed, 15 Aug 2012 10:07:53 +0200 [thread overview]
Message-ID: <20120815080752.GC3622@osiris.de.ibm.com> (raw)
In-Reply-To: <1344765694-7465-2-git-send-email-geert@linux-m68k.org>
On Sun, Aug 12, 2012 at 12:01:34PM +0200, Geert Uytterhoeven wrote:
> On s390x-linux-gcc, __SIZE_TYPE__ expands to "long unsigned int" for both
> 32-bit s390 and 64-bit s390x, as
> gcc-4.6.3-nolibc/s390x-linux/lib/gcc/s390x-linux/4.6.3/plugin/include/config/s390/linux.h
> has
>
> #define SIZE_TYPE (TARGET_64BIT ? "long unsigned int" : "long unsigned int")
>
> To match this, __kernel_size_t is always set to "long unsigned int".
>
> But while __kernel_ssize_t is "long" on 64-bit s390x, it is "int" on 32-bit
> s390, causing compiler warnings like:
>
> fs/quota/quota_tree.c:372:4: warning: format '%zd' expects argument of type 'signed size_t', but argument 4 has type 'ssize_t' [-Wformat]
>
> To fix this, __kernel_ssize_t should be "long", irrespective of word size.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied. Thanks Geert!
prev parent reply other threads:[~2012-08-15 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 10:01 [PATCH 1/2] cris: Use "int" for ssize_t to match size_t Geert Uytterhoeven
2012-08-12 10:01 ` [PATCH 2/2] s390: Always use "long" " Geert Uytterhoeven
2012-08-15 8:07 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815080752.GC3622@osiris.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.