From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] lib, panic: don't call do_reset in SPL (debug).
Date: Wed, 15 Aug 2012 10:11:18 -0700 [thread overview]
Message-ID: <20120815171118.GC23290@bill-the-cat> (raw)
In-Reply-To: <502AB7D2.80503@myspectrum.nl>
On Tue, Aug 14, 2012 at 10:40:50PM +0200, Jeroen Hofstee wrote:
> Several omap boards won't build when DEBUG is defined, SPL build error:
> "vsprintf.c:791: undefined reference to `do_reset'", since SPL has no
> commands. Therefore don't call do_reset in SPL. SPL panic will end in an
> endless loop or call hang if CONFIG_PANIC_HANG is defined.
>
> cc: Tom Rini <trini@ti.com>
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
OK, the problem I see with this is it forces a policy on everyone, even
non-DEBUG cases. What I'd like to see, and I'll submit the patch, is to
document that when debugging SPL one should also set CONFIG_PANIC_HANG
as do_reset is often (but it could be defined!) undefined for SPL.
--
Tom
next prev parent reply other threads:[~2012-08-15 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 20:37 [U-Boot] [PATCH 0/1] fix some SPL debug builds Jeroen Hofstee
2012-08-14 20:40 ` [U-Boot] [PATCH 1/1] lib, panic: don't call do_reset in SPL (debug) Jeroen Hofstee
2012-08-15 17:11 ` Tom Rini [this message]
2012-08-17 10:51 ` Stefano Babic
2012-08-24 19:30 ` Tom Rini
2012-09-02 17:03 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815171118.GC23290@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.