From: Oleg Nesterov <oleg@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Fengguang Wu <fengguang.wu@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: yama_ptrace_access_check(): possible recursive locking detected
Date: Wed, 15 Aug 2012 20:17:11 +0200 [thread overview]
Message-ID: <20120815181711.GA19018@redhat.com> (raw)
In-Reply-To: <CAGXu5jJ+HOdSxS7Ec=TW06h6KEpEmi-rF+Jk8L5LiQsp9gyAtg@mail.gmail.com>
On 08/15, Kees Cook wrote:
>
> It sounds like get_task_comm shouldn't have locking at all then? It
> should just do a length-limited copy
Without task_lock() get_task_comm() can copy incomplete new name.
Honestly, I do not know any user which "strictly" needs the correct
name. may be proc.
> and make sure there is a trailing
> 0-byte?
get_task_comm()->strncpy() should always see (and copy) 0-byte.
comm[TASK_COMM_LEN - 1] == '\0' and this byte is never changed.
set_task_comm()->strlcpy() can write to this byte, but it can
only write 0 again.
Or I am totally confused ;)
Oleg.
next prev parent reply other threads:[~2012-08-15 18:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 13:47 yama_ptrace_access_check(): possible recursive locking detected Fengguang Wu
2012-07-26 15:41 ` Oleg Nesterov
2012-07-30 17:00 ` Kees Cook
2012-08-10 1:39 ` Kees Cook
2012-08-10 1:52 ` Fengguang Wu
2012-08-14 21:16 ` Kees Cook
2012-08-15 3:01 ` Fengguang Wu
2012-08-15 5:56 ` Kees Cook
2012-08-15 8:05 ` Peter Zijlstra
2012-08-15 13:01 ` Oleg Nesterov
2012-08-15 14:30 ` Peter Zijlstra
2012-08-15 17:56 ` Oleg Nesterov
2012-08-15 18:09 ` Kees Cook
2012-08-15 18:17 ` Oleg Nesterov [this message]
2012-08-15 18:30 ` Kees Cook
2012-08-15 18:44 ` Alan Cox
2012-08-15 18:43 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815181711.GA19018@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=fengguang.wu@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.