Re: [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS

[Denys Dmytriyenko <denis@denix.org>]

On Tue, Aug 14, 2012 at 09:11:27PM +0000, Cooper Jr., Franklin wrote:
> That makes sense. Will do so in the future. Thx

Thanks. The point is to ensure every commit is atomic and does not break the 
build - try to avoid having one patch break the build and another right after 
that to fix it. Patches should be split into functional entities, but it 
doesn't mean they always have to be one patch per recipe...

Denys


> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis@denix.org] 
> Sent: Tuesday, August 14, 2012 10:47 AM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
> 
> Franklin,
> 
> Just a nit-pick for the future - to not break bisectability, you should 
> normally do this in 2 commits:
> 
> 1. add oprofile-example recipe AND switch the RDEPENDS
> 2. remove the old reference from am-sysinfo
> 
> Denys
> 
> 
> On Mon, Aug 13, 2012 at 10:57:07AM -0500, Franklin S Cooper Jr wrote:
> > * Replace the RDEPENDS from am-sysinfo to oprofile-example.
> >   The application oprofile-example use to be located within
> >   am-sysinfo but now is located in its own repository.
> > 
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> >  .../matrix/matrix-gui-oprofile-demos_2.0.bb        |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> > index e8aad0b..d3246f9 100644
> > --- a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> > +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> > @@ -4,7 +4,7 @@ LICENSE = "CC-BY-SA"
> >  
> >  require matrix-gui-apps-git.inc
> >  
> > -PR = "${INC_PR}.0"
> > +PR = "${INC_PR}.1"
> >  
> >  inherit allarch
> >  
> > @@ -13,6 +13,6 @@ S = "${WORKDIR}/git/oprofile_apps"
> >  # Make sure profiling submenu and app images  has been installed
> >  # Include am-sysinfo because that package has the sample
> >  # executables for profiling.
> > -RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile am-sysinfo"
> > +RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile oprofile-example"
> >  
> >  FILES_${PN} += "${MATRIX_BASE_DIR}/*"
> > -- 
> > 1.7.0.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > 
>