* Re: [meta-argo][PATCH] am-sysinfo: Remove oprofile-example
2012-08-13 15:57 ` [meta-argo][PATCH] am-sysinfo: Remove oprofile-example Franklin S Cooper Jr
@ 2012-08-13 15:51 ` Cooper Jr., Franklin
0 siblings, 0 replies; 7+ messages in thread
From: Cooper Jr., Franklin @ 2012-08-13 15:51 UTC (permalink / raw)
To: Cooper Jr., Franklin, meta-arago@arago-project.org; +Cc: Cooper Jr., Franklin
Please ignore this patch. Updated patch has been sent.
-----Original Message-----
From: Cooper Jr., Franklin
Sent: Monday, August 13, 2012 10:57 AM
To: meta-arago@arago-project.org
Cc: Cooper Jr., Franklin
Subject: [meta-argo][PATCH] am-sysinfo: Remove oprofile-example
* The application oprofile-example has been removed from within am-sysinfo
Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
.../recipes-core/am-sysinfo/am-sysinfo_svn.bb | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb b/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb
index 40daafa..78d8a97 100644
--- a/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb
+++ b/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb
@@ -7,9 +7,9 @@ SECTION = "system"
PACKAGE_STRIP = "no"
-SRCREV = "16"
+SRCREV = "17"
PV = "1.0"
-PR = "r3+svnr${SRCPV}"
+PR = "r4+svnr${SRCPV}"
SRC_URI = "svn://gforge.ti.com/svn/am_sysinfo/;module=trunk;protocol=https;user=anonymous;pswd=''"
@@ -17,13 +17,9 @@ S = "${WORKDIR}/trunk"
do_compile() {
${CC} ${CFLAGS} ${LDFLAGS} -o mem_util/mem_util mem_util/mem_util.c
- ${CC} ${CFLAGS} ${LDFLAGS} -o oprofile_example/Debug/signal_parent oprofile_example/signal_parent.c
- ${CC} ${CFLAGS} -DUSE_SIGNALS ${LDFLAGS} -o oprofile_example/Debug1/signal_parent.opt oprofile_example/signal_parent.c
}
do_install() {
install -d ${D}/${bindir}
install -m 0755 ${S}/mem_util/mem_util ${D}/${bindir}
- install -m 0755 ${S}/oprofile_example/Debug/signal_parent ${D}/${bindir}
- install -m 0755 ${S}/oprofile_example/Debug1/signal_parent.opt ${D}/${bindir}
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] oprofile-example: Create oprofile-example application
@ 2012-08-13 15:57 Franklin S Cooper Jr
2012-08-13 15:57 ` [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS Franklin S Cooper Jr
2012-08-13 15:57 ` [meta-argo][PATCH] am-sysinfo: Remove oprofile-example Franklin S Cooper Jr
0 siblings, 2 replies; 7+ messages in thread
From: Franklin S Cooper Jr @ 2012-08-13 15:57 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S Cooper Jr
* This application was split from am-sysinfo.
Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
.../oprofile-example/oprofile-example_git.bb | 30 ++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
create mode 100644 meta-arago-extras/recipes-core/oprofile-example/oprofile-example_git.bb
diff --git a/meta-arago-extras/recipes-core/oprofile-example/oprofile-example_git.bb b/meta-arago-extras/recipes-core/oprofile-example/oprofile-example_git.bb
new file mode 100644
index 0000000..79278fb
--- /dev/null
+++ b/meta-arago-extras/recipes-core/oprofile-example/oprofile-example_git.bb
@@ -0,0 +1,30 @@
+DESCRIPTION = "OProfile Example"
+HOMEPAGE = "https://gitorious.org/oprofile-example"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://signal_parent.c;beginline=1;endline=37;md5=3c72149bb458105db5d2e6fbcb2da66e"
+
+SECTION = "system"
+
+PACKAGE_STRIP = "no"
+
+PR = "r0"
+
+BRANCH ?= "master"
+SRCREV = "875147fcaf0706f91b1bcbf9d80821de78257955"
+
+SRC_URI = "git://gitorious.org/oprofile-example/oprofile-example.git;protocol=git;branch=${BRANCH}"
+
+S = "${WORKDIR}/git"
+
+do_compile() {
+ install -d ${S}/Debug
+ install -d ${S}/Debug1
+ ${CC} ${CFLAGS} ${LDFLAGS} -o Debug/signal_parent signal_parent.c
+ ${CC} ${CFLAGS} -DUSE_SIGNALS ${LDFLAGS} -o Debug1/signal_parent.opt signal_parent.c
+}
+
+do_install() {
+ install -d ${D}/${bindir}
+ install -m 0755 ${S}/Debug/signal_parent ${D}/${bindir}
+ install -m 0755 ${S}/Debug1/signal_parent.opt ${D}/${bindir}
+}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
2012-08-13 15:57 [PATCH] oprofile-example: Create oprofile-example application Franklin S Cooper Jr
@ 2012-08-13 15:57 ` Franklin S Cooper Jr
2012-08-14 15:46 ` Denys Dmytriyenko
2012-08-13 15:57 ` [meta-argo][PATCH] am-sysinfo: Remove oprofile-example Franklin S Cooper Jr
1 sibling, 1 reply; 7+ messages in thread
From: Franklin S Cooper Jr @ 2012-08-13 15:57 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S Cooper Jr
* Replace the RDEPENDS from am-sysinfo to oprofile-example.
The application oprofile-example use to be located within
am-sysinfo but now is located in its own repository.
Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
.../matrix/matrix-gui-oprofile-demos_2.0.bb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
index e8aad0b..d3246f9 100644
--- a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
@@ -4,7 +4,7 @@ LICENSE = "CC-BY-SA"
require matrix-gui-apps-git.inc
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
inherit allarch
@@ -13,6 +13,6 @@ S = "${WORKDIR}/git/oprofile_apps"
# Make sure profiling submenu and app images has been installed
# Include am-sysinfo because that package has the sample
# executables for profiling.
-RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile am-sysinfo"
+RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile oprofile-example"
FILES_${PN} += "${MATRIX_BASE_DIR}/*"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [meta-argo][PATCH] am-sysinfo: Remove oprofile-example
2012-08-13 15:57 [PATCH] oprofile-example: Create oprofile-example application Franklin S Cooper Jr
2012-08-13 15:57 ` [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS Franklin S Cooper Jr
@ 2012-08-13 15:57 ` Franklin S Cooper Jr
2012-08-13 15:51 ` Cooper Jr., Franklin
1 sibling, 1 reply; 7+ messages in thread
From: Franklin S Cooper Jr @ 2012-08-13 15:57 UTC (permalink / raw)
To: meta-arago; +Cc: Franklin S Cooper Jr
* The application oprofile-example has been removed from within am-sysinfo
Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
.../recipes-core/am-sysinfo/am-sysinfo_svn.bb | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb b/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb
index 40daafa..78d8a97 100644
--- a/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb
+++ b/meta-arago-extras/recipes-core/am-sysinfo/am-sysinfo_svn.bb
@@ -7,9 +7,9 @@ SECTION = "system"
PACKAGE_STRIP = "no"
-SRCREV = "16"
+SRCREV = "17"
PV = "1.0"
-PR = "r3+svnr${SRCPV}"
+PR = "r4+svnr${SRCPV}"
SRC_URI = "svn://gforge.ti.com/svn/am_sysinfo/;module=trunk;protocol=https;user=anonymous;pswd=''"
@@ -17,13 +17,9 @@ S = "${WORKDIR}/trunk"
do_compile() {
${CC} ${CFLAGS} ${LDFLAGS} -o mem_util/mem_util mem_util/mem_util.c
- ${CC} ${CFLAGS} ${LDFLAGS} -o oprofile_example/Debug/signal_parent oprofile_example/signal_parent.c
- ${CC} ${CFLAGS} -DUSE_SIGNALS ${LDFLAGS} -o oprofile_example/Debug1/signal_parent.opt oprofile_example/signal_parent.c
}
do_install() {
install -d ${D}/${bindir}
install -m 0755 ${S}/mem_util/mem_util ${D}/${bindir}
- install -m 0755 ${S}/oprofile_example/Debug/signal_parent ${D}/${bindir}
- install -m 0755 ${S}/oprofile_example/Debug1/signal_parent.opt ${D}/${bindir}
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
2012-08-13 15:57 ` [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS Franklin S Cooper Jr
@ 2012-08-14 15:46 ` Denys Dmytriyenko
2012-08-14 21:11 ` Cooper Jr., Franklin
0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2012-08-14 15:46 UTC (permalink / raw)
To: Franklin S Cooper Jr; +Cc: meta-arago
Franklin,
Just a nit-pick for the future - to not break bisectability, you should
normally do this in 2 commits:
1. add oprofile-example recipe AND switch the RDEPENDS
2. remove the old reference from am-sysinfo
Denys
On Mon, Aug 13, 2012 at 10:57:07AM -0500, Franklin S Cooper Jr wrote:
> * Replace the RDEPENDS from am-sysinfo to oprofile-example.
> The application oprofile-example use to be located within
> am-sysinfo but now is located in its own repository.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
> .../matrix/matrix-gui-oprofile-demos_2.0.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> index e8aad0b..d3246f9 100644
> --- a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> @@ -4,7 +4,7 @@ LICENSE = "CC-BY-SA"
>
> require matrix-gui-apps-git.inc
>
> -PR = "${INC_PR}.0"
> +PR = "${INC_PR}.1"
>
> inherit allarch
>
> @@ -13,6 +13,6 @@ S = "${WORKDIR}/git/oprofile_apps"
> # Make sure profiling submenu and app images has been installed
> # Include am-sysinfo because that package has the sample
> # executables for profiling.
> -RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile am-sysinfo"
> +RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile oprofile-example"
>
> FILES_${PN} += "${MATRIX_BASE_DIR}/*"
> --
> 1.7.0.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
2012-08-14 15:46 ` Denys Dmytriyenko
@ 2012-08-14 21:11 ` Cooper Jr., Franklin
2012-08-15 19:30 ` Denys Dmytriyenko
0 siblings, 1 reply; 7+ messages in thread
From: Cooper Jr., Franklin @ 2012-08-14 21:11 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-arago@arago-project.org, Cooper Jr., Franklin
That makes sense. Will do so in the future. Thx
-----Original Message-----
From: Denys Dmytriyenko [mailto:denis@denix.org]
Sent: Tuesday, August 14, 2012 10:47 AM
To: Cooper Jr., Franklin
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
Franklin,
Just a nit-pick for the future - to not break bisectability, you should
normally do this in 2 commits:
1. add oprofile-example recipe AND switch the RDEPENDS
2. remove the old reference from am-sysinfo
Denys
On Mon, Aug 13, 2012 at 10:57:07AM -0500, Franklin S Cooper Jr wrote:
> * Replace the RDEPENDS from am-sysinfo to oprofile-example.
> The application oprofile-example use to be located within
> am-sysinfo but now is located in its own repository.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
> .../matrix/matrix-gui-oprofile-demos_2.0.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> index e8aad0b..d3246f9 100644
> --- a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> @@ -4,7 +4,7 @@ LICENSE = "CC-BY-SA"
>
> require matrix-gui-apps-git.inc
>
> -PR = "${INC_PR}.0"
> +PR = "${INC_PR}.1"
>
> inherit allarch
>
> @@ -13,6 +13,6 @@ S = "${WORKDIR}/git/oprofile_apps"
> # Make sure profiling submenu and app images has been installed
> # Include am-sysinfo because that package has the sample
> # executables for profiling.
> -RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile am-sysinfo"
> +RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile oprofile-example"
>
> FILES_${PN} += "${MATRIX_BASE_DIR}/*"
> --
> 1.7.0.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
2012-08-14 21:11 ` Cooper Jr., Franklin
@ 2012-08-15 19:30 ` Denys Dmytriyenko
0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2012-08-15 19:30 UTC (permalink / raw)
To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org
On Tue, Aug 14, 2012 at 09:11:27PM +0000, Cooper Jr., Franklin wrote:
> That makes sense. Will do so in the future. Thx
Thanks. The point is to ensure every commit is atomic and does not break the
build - try to avoid having one patch break the build and another right after
that to fix it. Patches should be split into functional entities, but it
doesn't mean they always have to be one patch per recipe...
Denys
> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis@denix.org]
> Sent: Tuesday, August 14, 2012 10:47 AM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS
>
> Franklin,
>
> Just a nit-pick for the future - to not break bisectability, you should
> normally do this in 2 commits:
>
> 1. add oprofile-example recipe AND switch the RDEPENDS
> 2. remove the old reference from am-sysinfo
>
> Denys
>
>
> On Mon, Aug 13, 2012 at 10:57:07AM -0500, Franklin S Cooper Jr wrote:
> > * Replace the RDEPENDS from am-sysinfo to oprofile-example.
> > The application oprofile-example use to be located within
> > am-sysinfo but now is located in its own repository.
> >
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> > .../matrix/matrix-gui-oprofile-demos_2.0.bb | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> > index e8aad0b..d3246f9 100644
> > --- a/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> > +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-oprofile-demos_2.0.bb
> > @@ -4,7 +4,7 @@ LICENSE = "CC-BY-SA"
> >
> > require matrix-gui-apps-git.inc
> >
> > -PR = "${INC_PR}.0"
> > +PR = "${INC_PR}.1"
> >
> > inherit allarch
> >
> > @@ -13,6 +13,6 @@ S = "${WORKDIR}/git/oprofile_apps"
> > # Make sure profiling submenu and app images has been installed
> > # Include am-sysinfo because that package has the sample
> > # executables for profiling.
> > -RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile am-sysinfo"
> > +RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-oprofile oprofile oprofile-example"
> >
> > FILES_${PN} += "${MATRIX_BASE_DIR}/*"
> > --
> > 1.7.0.4
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-08-15 19:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-13 15:57 [PATCH] oprofile-example: Create oprofile-example application Franklin S Cooper Jr
2012-08-13 15:57 ` [PATCH] matrix-gui-oprofile-demos: Update RDEPENDS Franklin S Cooper Jr
2012-08-14 15:46 ` Denys Dmytriyenko
2012-08-14 21:11 ` Cooper Jr., Franklin
2012-08-15 19:30 ` Denys Dmytriyenko
2012-08-13 15:57 ` [meta-argo][PATCH] am-sysinfo: Remove oprofile-example Franklin S Cooper Jr
2012-08-13 15:51 ` Cooper Jr., Franklin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.