From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: PATCH Add support for the Iomega IX2-200 Device Tree
Date: Wed, 15 Aug 2012 23:15:17 +0200 [thread overview]
Message-ID: <20120815211517.GA15830@lunn.ch> (raw)
In-Reply-To: <CADhrpJ5JEGQWAjwu5+=Hy_gFjWLkkrzj9E0dZ-vxMk9x+M5uCA@mail.gmail.com>
Hi Alan
...
> i did what you sujested and all commands worked except for the git
> sendmail part so i do not know if I should still be sending you the
> patch this way but here it is. i also defined the gpio keys in the dts
> file like you said the same as with the iconnect but the kernel keeps
> crashing with them defined in the dts is the support actualy there for
> the keys? or have i just defined them wrong?
...
> + sata at 80000 {
> + compatible = "marvell,orion-sata";
> + reg = <0x80000 0x5000>;
> + interrupts = <21>;
> + status = "okay";
> + nr-ports = <2>;
> + };
You should not need all the values above. All you need is what is
different to the defaults in kirkwood.dtsi. So i _think_ you need:
sata at 80000 {
status = "okay";
nr-ports = <2>;
};
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + button at 1 {
> + label = "OTB Button";
> + linux,code = <0x00>;
0x00 seems odd.
>From <linux/input.h>
#define KEY_RESERVED 0
> + gpios = <&gpio1 4 1>;
> + debounce-interval = <100>;
> + };
> + button at 2 {
> + label = "Reset";
> + linux,code = <0x01>;
0x01 seems odd.
#define KEY_ESC 1
> + gpios = <&gpio0 12 1>;
> + debounce-interval = <100>;
> + };
> + button at 3 {
> + label = "Power";
> + linux,code = <0x028>;
#define KEY_APOSTROPHE 40
???
Andrew
next prev parent reply other threads:[~2012-08-15 21:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 20:06 PATCH Add support for the Iomega IX2-200 Device Tree Ownerx35
2012-08-14 23:56 ` Jason Cooper
2012-08-15 8:36 ` Alan M Butler
2012-08-15 11:12 ` Jason Cooper
2012-08-15 11:55 ` Josh Coombs
2012-08-15 12:11 ` Jason Cooper
2012-08-15 12:43 ` alan butler
2012-08-15 13:54 ` Jason Cooper
2012-08-15 18:00 ` alan butler
2012-08-15 20:19 ` Jason Cooper
2012-08-15 20:56 ` alan butler
2012-08-15 22:58 ` Jason Cooper
2012-08-15 21:15 ` Andrew Lunn [this message]
2012-08-15 21:23 ` alan butler
[not found] ` <20120815213221.GE15830@lunn.ch>
[not found] ` <CADhrpJ4eAUdDaLF8OXvjRf6oA6ya0na-SHYs43eoNwdoEJETpA@mail.gmail.com>
[not found] ` <20120815215237.GF15830@lunn.ch>
2012-08-15 21:57 ` alan butler
[not found] ` <20120815221613.GH15830@lunn.ch>
[not found] ` <CADhrpJ66ncpT74ATyvJDXTuJC-zrmh8vQ99RPg0t=XuQ_2RcVA@mail.gmail.com>
2012-08-15 23:12 ` alan butler
2012-08-15 23:34 ` alan butler
2012-08-15 23:41 ` Jason Cooper
2012-08-15 23:52 ` alan butler
[not found] ` <CADhrpJ5UF6r2N027nOS6xmJtu21UbDxfzLninCZ7O-A+G3ALgg@mail.gmail.com>
2012-08-16 10:36 ` alan butler
2012-08-16 22:10 ` Andrew Lunn
2012-08-17 0:03 ` Fabio Estevam
2012-08-16 12:43 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815211517.GA15830@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.