All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	James Bottomley <jbottomley@parallels.com>,
	Matthew Helsley <matt.helsley@gmail.com>
Subject: Re: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers
Date: Thu, 16 Aug 2012 01:34:49 +0400	[thread overview]
Message-ID: <20120815213449.GQ23657@moon> (raw)
In-Reply-To: <20120815212927.GO23464@ZenIV.linux.org.uk>

On Wed, Aug 15, 2012 at 10:29:27PM +0100, Al Viro wrote:
> 
> This, BTW, is too convoluted for its own good.  What you need is
> something like
> struct whatever {
> 	struct seq_file *m;
> 	struct file *f;
> 	int flags;
> };
> with single allocation of that sucker in your ->open().  Set
> file->private_data to address of seq_file field in your object *before*
> calling seq_open() and don't bother with m->private at all - just use
> container_of(m, struct whatever, m) in your ->show() to get to that
> structure...

I will try and post results, thanks!

	Cyrill

  reply	other threads:[~2012-08-15 21:34 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15  9:21 [patch 0/8] procfs, fdinfo updated Cyrill Gorcunov
2012-08-15  9:21 ` [patch 1/8] procfs: Move /proc/pid/fd[info] handling code to fd.[ch] Cyrill Gorcunov
2012-08-15  9:21 ` [patch 2/8] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file Cyrill Gorcunov
2012-08-15  9:21 ` [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers Cyrill Gorcunov
2012-08-15 21:16   ` Al Viro
2012-08-15 21:31     ` Cyrill Gorcunov
2012-08-15 21:29   ` Al Viro
2012-08-15 21:34     ` Cyrill Gorcunov [this message]
2012-08-16 10:58     ` Cyrill Gorcunov
2012-08-15  9:21 ` [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Cyrill Gorcunov
2012-08-15 20:45   ` J. Bruce Fields
2012-08-15 21:02     ` Cyrill Gorcunov
2012-08-15 22:06       ` J. Bruce Fields
2012-08-16  6:24         ` Cyrill Gorcunov
2012-08-16 12:38           ` Cyrill Gorcunov
2012-08-16 12:47             ` J. Bruce Fields
2012-08-16 13:16               ` Cyrill Gorcunov
2012-08-16 14:57               ` Cyrill Gorcunov
2012-08-16 15:05                 ` Al Viro
2012-08-16 15:09                   ` Cyrill Gorcunov
2012-08-16 13:43             ` Al Viro
2012-08-16 13:47               ` Pavel Emelyanov
2012-08-16 13:50                 ` Al Viro
2012-08-16 13:53                   ` Pavel Emelyanov
2012-08-16 13:54                   ` Cyrill Gorcunov
2012-08-16 14:03                     ` James Bottomley
2012-08-16 14:03                       ` James Bottomley
2012-08-16 14:13                       ` Pavel Emelyanov
2012-08-16 14:15                       ` Cyrill Gorcunov
2012-08-16 14:41                         ` Al Viro
2012-08-16 14:48                           ` Cyrill Gorcunov
2012-08-16 14:54                             ` J. Bruce Fields
2012-08-16 14:55                             ` Al Viro
2012-08-16 15:06                               ` Pavel Emelyanov
2012-08-16 15:35                                 ` Cyrill Gorcunov
2012-08-16 15:07                               ` Cyrill Gorcunov
2012-08-17 20:58                           ` Eric W. Biederman
2012-08-16 13:48               ` Al Viro
2012-08-20 14:19   ` Aneesh Kumar K.V
2012-08-20 16:33     ` Cyrill Gorcunov
2012-08-20 18:32       ` J. Bruce Fields
2012-08-20 19:06         ` Cyrill Gorcunov
2012-08-20 19:32           ` J. Bruce Fields
2012-08-20 19:40             ` Cyrill Gorcunov
2012-08-21  9:18             ` Pavel Emelyanov
2012-08-21 10:42               ` Aneesh Kumar K.V
2012-08-21 10:49                 ` Pavel Emelyanov
2012-08-21 10:54                   ` Cyrill Gorcunov
2012-08-21 11:09                     ` Pavel Emelyanov
2012-08-21 12:11                       ` J. Bruce Fields
2012-08-21 12:22                         ` Pavel Emelyanov
2012-08-21 12:29                           ` J. Bruce Fields
2012-08-21 12:40                             ` Pavel Emelyanov
2012-08-21 12:51                             ` Boaz Harrosh
2012-08-21 12:59                               ` Pavel Emelyanov
2012-08-21 13:08                                 ` Boaz Harrosh
2012-08-21 13:12                               ` Al Viro
2012-08-21 13:40                             ` Cyrill Gorcunov
2012-08-21 12:09                   ` J. Bruce Fields
2012-08-21 12:25                     ` Pavel Emelyanov
2012-08-22  5:49                   ` Aneesh Kumar K.V
2012-08-23  8:06                     ` Cyrill Gorcunov
2012-08-23  8:54                       ` Marco Stornelli
2012-08-23  9:29                         ` Cyrill Gorcunov
2012-08-15  9:21 ` [patch 5/8] fs, notify: Add procfs fdinfo helper v3 Cyrill Gorcunov
2012-08-15  9:21 ` [patch 6/8] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-08-15  9:21 ` [patch 7/8] fs, epoll: Add procfs fdinfo helper v2 Cyrill Gorcunov
2012-08-15  9:21 ` [patch 8/8] fdinfo: Show sigmask for signalfd fd v2 Cyrill Gorcunov
  -- strict thread matches above, loose matches on Subject: below --
2012-08-14 14:03 [patch 0/8] procfs fdinfo providers updated Cyrill Gorcunov
2012-08-14 14:03 ` [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers Cyrill Gorcunov
2012-08-14 14:22   ` Pavel Emelyanov
2012-08-14 18:31   ` Al Viro
2012-08-14 18:35     ` Cyrill Gorcunov
2012-08-14 19:56       ` Cyrill Gorcunov
2012-08-14 21:27         ` Al Viro
2012-08-14 21:56           ` Cyrill Gorcunov
2012-08-14 22:21             ` Cyrill Gorcunov
2012-08-15  0:07               ` Al Viro
2012-08-15  7:40                 ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815213449.GQ23657@moon \
    --to=gorcunov@openvz.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jbottomley@parallels.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.helsley@gmail.com \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.