diff for duplicates of <20120816004615.GA3870@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index d134001..14768de 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -26,7 +26,7 @@ its parent ? > +++ b/Documentation/hwmon/da9058 > @@ -0,0 +1,30 @@ > +Kernel driver da9058-hwmon -> +============= +> +========================== > + > +Supported chips: > + * Dialog Semiconductor DA9058 PMIC @@ -478,7 +478,7 @@ temp attributes start with temp1. > + struct da9058_hwmon *hwmon; > + int ret; > + -> + if (cell = NULL) { +> + if (cell == NULL) { > + ret = -ENODEV; > + goto exit; @@ -489,7 +489,7 @@ temp attributes start with temp1. > + > + hwmon_pdata = cell->platform_data; > + -> + if (hwmon_pdata = NULL) { +> + if (hwmon_pdata == NULL) { > + ret = -EINVAL; > + goto exit; > + } @@ -562,8 +562,10 @@ are accesible, but you did not call the init function yet, meaning the device may not be completely initialized. Initialize first, then create sysfs files, to avoid such problems. -> + hwmon->exit_hwmon_platform_callback > + hwmon_pdata->exit_hwmon_platform_callback; -> + hwmon->init_hwmon_platform_callback > + hwmon_pdata->init_hwmon_platform_callback; +> + hwmon->exit_hwmon_platform_callback = +> + hwmon_pdata->exit_hwmon_platform_callback; +> + hwmon->init_hwmon_platform_callback = +> + hwmon_pdata->init_hwmon_platform_callback; > + > + if (hwmon_pdata->init_hwmon_platform_callback) > + hwmon_pdata->init_hwmon_platform_callback(hwmon); @@ -615,9 +617,4 @@ Please check all alignments. > -- > end-of-patch for NEW DRIVER V3 > -> - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors +> diff --git a/a/content_digest b/N1/content_digest index fef52bc..5455199 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0201208151518.q7FFIMHq011609@latitude.olech.com\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] [NEW DRIVER V3 7/8] DA9058 HWMON driver\0" - "Date\0Thu, 16 Aug 2012 00:46:15 +0000\0" + "Subject\0Re: [NEW DRIVER V3 7/8] DA9058 HWMON driver\0" + "Date\0Wed, 15 Aug 2012 17:46:15 -0700\0" "To\0Anthony Olech <anthony.olech.opensource@diasemi.com>\0" "Cc\0Jean Delvare <khali@linux-fr.org>" Mark Brown <broonie@opensource.wolfsonmicro.com> @@ -39,7 +39,7 @@ "> +++ b/Documentation/hwmon/da9058\n" "> @@ -0,0 +1,30 @@\n" "> +Kernel driver da9058-hwmon\n" - "> +=============\n" + "> +==========================\n" "> +\n" "> +Supported chips:\n" "> + * Dialog Semiconductor DA9058 PMIC\n" @@ -491,7 +491,7 @@ "> +\tstruct da9058_hwmon *hwmon;\n" "> +\tint ret;\n" "> +\n" - "> +\tif (cell = NULL) {\n" + "> +\tif (cell == NULL) {\n" "> +\t\tret = -ENODEV;\n" "> +\t\tgoto exit;\n" "\n" @@ -502,7 +502,7 @@ "> +\n" "> +\thwmon_pdata = cell->platform_data;\n" "> +\n" - "> +\tif (hwmon_pdata = NULL) {\n" + "> +\tif (hwmon_pdata == NULL) {\n" "> +\t\tret = -EINVAL;\n" "> +\t\tgoto exit;\n" "> +\t}\n" @@ -575,8 +575,10 @@ "may not be completely initialized. Initialize first, then create sysfs files, to\n" "avoid such problems.\n" "\n" - "> +\thwmon->exit_hwmon_platform_callback > +\t\t\t\thwmon_pdata->exit_hwmon_platform_callback;\n" - "> +\thwmon->init_hwmon_platform_callback > +\t\t\t\thwmon_pdata->init_hwmon_platform_callback;\n" + "> +\thwmon->exit_hwmon_platform_callback =\n" + "> +\t\t\t\thwmon_pdata->exit_hwmon_platform_callback;\n" + "> +\thwmon->init_hwmon_platform_callback =\n" + "> +\t\t\t\thwmon_pdata->init_hwmon_platform_callback;\n" "> +\n" "> +\tif (hwmon_pdata->init_hwmon_platform_callback)\n" "> +\t\t\thwmon_pdata->init_hwmon_platform_callback(hwmon);\n" @@ -628,11 +630,6 @@ "> -- \n" "> end-of-patch for NEW DRIVER V3\n" "> \n" - "> \n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + > -2c202e115019ea2639db5018ed22646b22fdfb1613c8bcca94a5c3317287eeaa +6c7cb9342ceea5a1939cd5d99d3d3e46131ce5769e883f76ab4b82b8bc2a63b2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.