From: Johan Hedberg <johan.hedberg@gmail.com>
To: "João Paulo Rechi Vita" <jprvita@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v2 04/14] core: Add a list of LE devices to connect
Date: Thu, 16 Aug 2012 12:20:32 +0300 [thread overview]
Message-ID: <20120816092032.GA31761@x220> (raw)
In-Reply-To: <1345042253-15053-5-git-send-email-jprvita@openbossa.org>
Hi João Paulo,
On Wed, Aug 15, 2012, João Paulo Rechi Vita wrote:
> + device_get_address(device, &bdaddr, NULL);
> + if (g_slist_find_custom(adapter->connect_list, &bdaddr,
> + (GCompareFunc) device_bdaddr_cmp)) {
> + DBG("trying to add device %s which is already in the connect "
> + "list, ignoring", device_get_path(device));
> + return;
> + }
Why don't you just use g_slist_find here? If this is the only place
where you need the new device_bdaddr_cmp then patch 03/14 can be
removed.
Johan
next prev parent reply other threads:[~2012-08-16 9:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 14:50 [PATCH BlueZ v2 00/14] LE General Connection Establishment procedure João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 01/14] core: Control connections based on adapter state João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 02/14] mgmt: print error message when start_discovery fails João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 03/14] core: add compare function for bdaddr in a struct btd_device João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 04/14] core: Add a list of LE devices to connect João Paulo Rechi Vita
2012-08-16 9:20 ` Johan Hedberg [this message]
2012-08-16 20:40 ` Joao Paulo Rechi Vita
2012-08-16 9:21 ` Johan Hedberg
2012-08-15 14:50 ` [PATCH BlueZ v2 05/14] core: use adapter connect list for LE connections João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 06/14] core: mutually exclude concurrent connections João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 07/14] mgmt: Add LE scanning callback João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 08/14] core: Replace interleaved by LE scanning João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 09/14] core: Start LE scanning when a device requests João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 10/14] core: Remove leftover define João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 11/14] core: Queue discovery if scanning is active João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 12/14] test: Fix exiting the bus when a discovery session ends João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 13/14] core: Disable unnecessary auto connections João Paulo Rechi Vita
2012-08-15 14:50 ` [PATCH BlueZ v2 14/14] core: Re-connect for ECONNRESET or ECONNABORTED João Paulo Rechi Vita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816092032.GA31761@x220 \
--to=johan.hedberg@gmail.com \
--cc=jprvita@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.