From: Dan Carpenter <dan.carpenter@oracle.com>
To: shli@fusionio.com
Cc: linux-raid@vger.kernel.org
Subject: re: md: raid 10 supports TRIM
Date: Thu, 16 Aug 2012 14:02:38 +0300 [thread overview]
Message-ID: <20120816110237.GA4709@elgon.mountain> (raw)
Hello Shaohua Li,
This is a semi-automatic email about new static checker warnings.
The patch d61b764704ca: "md: raid 10 supports TRIM" from Aug 15,
2012, leads to the following Smatch complaint:
drivers/md/raid10.c:3510 run()
warn: variable dereferenced before check 'mddev->queue' (see line 3508)
drivers/md/raid10.c
3507
3508 blk_queue_max_discard_sectors(mddev->queue, mddev->chunk_sectors);
^^^^^^^^^^^^
New dereference.
3509 chunk_size = mddev->chunk_sectors << 9;
3510 if (mddev->queue) {
^^^^^^^^^^^^
Old check.
3511 blk_queue_io_min(mddev->queue, chunk_size);
3512 if (conf->geo.raid_disks % conf->geo.near_copies)
regards,
dan carpenter
next reply other threads:[~2012-08-16 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 11:02 Dan Carpenter [this message]
[not found] ` <502DAEB3.6080302@fusionio.com>
2012-08-17 4:00 ` md: raid 10 supports TRIM Shaohua Li
2012-08-17 8:41 ` Jan Ceuleers
2012-08-17 9:28 ` NeilBrown
2012-08-17 23:51 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816110237.GA4709@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fusionio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.