Re: [PATCH v2] power: add knob for printing device resume times

[Pavel Machek <pavel@ucw.cz>]

On Sat 2012-06-16 15:57:37, Rafael J. Wysocki wrote:
> On Friday, June 15, 2012, Greg KH wrote:
> > On Fri, Jun 15, 2012 at 12:00:20PM +0200, Rafael J. Wysocki wrote:
> > > On Friday, June 15, 2012, Greg KH wrote:
> > > > On Wed, May 23, 2012 at 09:45:32AM -0700, Sameer Nanda wrote:
> > > > > Added a new knob called /sys/power/pm_print_times. Setting it to 1
> > > > > enables printing of time taken by devices to suspend and resume.
> > > > > Setting it to 0 disables this printing (unless overridden by
> > > > > initcall_debug kernel command line option).
> > > > > 
> > > > > Signed-off-by: Sameer Nanda <snanda@chromium.org>
> > > > > cc: Greg KH <gregkh@linuxfoundation.org>
> > > > > cc: Rafael J. Wysocki <rjw@sisk.pl>
> > > > > cc: Steven Rostedt <rostedt@goodmis.org>
> > > > > ---
> > > > >  Documentation/ABI/testing/sysfs-power |   13 ++++++++++++
> > > > >  drivers/base/power/main.c             |    4 +-
> > > > >  drivers/base/power/power.h            |   11 ++++++++++
> > > > >  kernel/power/main.c                   |   34 +++++++++++++++++++++++++++++++++
> > > > >  4 files changed, 60 insertions(+), 2 deletions(-)
> > > > 
> > > > This patch fails against the linux-next tree, care to fix it up so that
> > > > I can apply it?
> > > 
> > > I'd prefer it to go through my tree if you don't mind.
> > 
> > Not at all, feel free to put:
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > When it shows up again.
> 
> I've just used the original one, it only needed a documentation merge conflict
> fixed.
> 
> Queued up for 3.6.

Umm. Is it good idea? 60 LoC is pretty much for something that already
has command line option?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html