From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 00/19] pci-assign: Refactor for upstream merge Date: Thu, 16 Aug 2012 19:07:47 +0300 Message-ID: <20120816160747.GA22494@redhat.com> References: <502D050B.9010303@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61576 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932812Ab2HPQGp (ORCPT ); Thu, 16 Aug 2012 12:06:45 -0400 Content-Disposition: inline In-Reply-To: <502D050B.9010303@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 16, 2012 at 05:34:51PM +0300, Avi Kivity wrote: > On 08/16/2012 04:54 PM, Jan Kiszka wrote: > > With this series, we are getting very close to obsoleting qemu-kvm. It > > refactors hw/device-assignment.c and the associated KVM helper functions > > into a form that should allow merging them into QEMU. Once the series is > > acceptable for qemu-kvm, I will break out the necessary uq/master > > patches and push pci-assign to upstream. > > > > The major step of this series is to define a regular set of kvm_device_* > > services that encapsulate classic (i.e. KVM-based, non-VFIO) device > > assignment features and export them to i386 targets only. There will > > never be another arch using them, therefore I pushed them into this > > corner. Moreover, the device assignment device now makes use of the new > > KVM IRQ/MSI routing API and no longer pokes into the internals of that > > layer. Finally, I moved the code into hw/kvm/pci-assign.c, dropped the > > superfluous configure option and did some basic code cleanups (mostly > > coding style) to bring things in shape. > > > > Note that patch 1 is a simple bug fix that should likely be applied for > > qemu-kvm-1.2 independently. > > > > This series depends on [1] and [2] and QEMU upstream (2b97f88c92) being > > merged into qemu-kvm. > > > > Please review. > > >From a quick review it looks ready to merge. Of course I'd appreciate a > review from Alex or Michael as well. Looks good to me too. Acked-by: Michael S. Tsirkin > -- > error compiling committee.c: too many arguments to function > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html