From: NeilBrown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "ZUIDAM, Hans" <Hans.Zuidam@philips.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"DE WITTE, PETER" <PETER.DE.WITTE@philips.com>
Subject: Re: Linux NFS and cached properties
Date: Fri, 17 Aug 2012 07:05:51 +1000 [thread overview]
Message-ID: <20120817070551.6cfc1346@notabene.brown> (raw)
In-Reply-To: <20120816191018.GA4385@fieldses.org>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
On Thu, 16 Aug 2012 15:10:18 -0400 "J. Bruce Fields" <bfields@fieldses.org>
wrote:
> On Thu, Aug 02, 2012 at 10:04:05AM +1000, NeilBrown wrote:
> > I never liked that fact that stopping the last thread did something extra.
> > So when I added the ability to control the number of threads via sysfs I made
>
> (You meant nfsd, not sysfs, right? Or is there some interface I'm
> overlooking?)
Right.
>
> > sure that it *only* controlled the number of threads. However I kept the
> > legacy behaviour that sending SIGKILL to the nfsd threads would also unexport
> > things. Obviously I should have documented this better.
> >
> > The more I think out it, the more I'd really like to go back to that. It
> > really is the *right* thing to do.
> ...
> > > > 1/ iterate through all no-sleeping threads setting a flag an increasing a
> > > > counter.
> > > > 2/ when a thread completes current request, if test_and_clear the flag, it
> > > > atomic_dec_and_test the counter and then wakes up some wait_queue_head.
> > > > 3/ 'flush'ing thread waits on the waut_queue_head for the counter to be 0.
> > > >
> > > > If you don't hate it I could possibly even provide some code.
>
> By the way, are you still looking into one of those approaches?
Not yet. Other things got in the way.
I made a note to remind me when room appears in my schedule. :-)
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-08-16 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D307B3AC0BCD4C419E6B8FA6A2720A9C0C3B2F@011-DB3MPN1-001.MGDPHG.emi.philips.com>
[not found] ` <20120724143748.GC8570@fieldses.org>
2012-07-24 17:28 ` Linux NFS and cached properties ZUIDAM, Hans
2012-07-26 22:36 ` J. Bruce Fields
2012-07-31 5:08 ` NeilBrown
2012-07-31 12:25 ` J. Bruce Fields
2012-07-31 12:45 ` J. Bruce Fields
2012-07-31 14:07 ` J. Bruce Fields
2012-08-02 0:04 ` NeilBrown
2012-08-02 2:50 ` J. Bruce Fields
2012-08-16 19:10 ` J. Bruce Fields
2012-08-16 21:05 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817070551.6cfc1346@notabene.brown \
--to=neilb@suse.de \
--cc=Hans.Zuidam@philips.com \
--cc=PETER.DE.WITTE@philips.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.