From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH V3] Make inode64 a remountable option
Date: Fri, 17 Aug 2012 11:49:50 -0300 [thread overview]
Message-ID: <20120817144950.GA17092@orion.usersys.redhat.com> (raw)
In-Reply-To: <20120817122437.GC2502@infradead.org>
On Fri, Aug 17, 2012 at 08:24:37AM -0400, Christoph Hellwig wrote:
> On Thu, Aug 16, 2012 at 11:39:38PM -0300, Carlos Maiolino wrote:
> > Actually, there is no reason about why a user must umount and mount a XFS
> > filesystem to enable 'inode64' option. So, this patch makes this a remountable
> > option.
>
> What does protect concurrent updates of m_flags?
>
I don't think there is any lock protection around m_flags, I did a search on the
code and couldn't find anything protecting it. At a first glance though, I don't
think there is a need to protect it once this flag is managed only during super
operations - mount/umount/remount -
Also, I *think* the sb->s_umount rw_semaphore is enough for protection, once it
protects the whole mount/umount operation, but I'm 100% sure of it.
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
--Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-17 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 2:39 [PATCH V3] Make inode64 a remountable option Carlos Maiolino
2012-08-17 5:04 ` Dave Chinner
2012-08-17 12:24 ` Christoph Hellwig
2012-08-17 14:49 ` Carlos Maiolino [this message]
2012-08-17 17:34 ` Christoph Hellwig
2012-08-17 17:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817144950.GA17092@orion.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.