Re: [patch 3/3] Add a dracut option --device to bring up a device in initramfs

[Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Fri, Aug 17, 2012 at 08:35:22PM +0800, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote:
> Kdump support dump to raw device which could be on top of complex storage
> such as multipath and iscsi which are standalone dracut modules.
> 
> Add a --device option to dracut which will add the device to host_devs so
> dracut can add the dependent modules automaticlly and enable them in initramfs.
> 
> --device will accept device node name as the param.

Last time you mentioned that device should be device node as /dev/sda. I
think that can fail due to device renaming.

So make sure to specify here that device name here should be persistent
device name as generated by udev. (/dev/disk/by-id/* or /dev/disk/by-uuid/*).

Thanks
Vivek

> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Tested-by: Chao Wang <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  dracut.8.asc |    3 +++
>  dracut.sh    |    3 +++
>  2 files changed, 6 insertions(+)
> 
> --- dracut.orig/dracut.sh
> +++ dracut/dracut.sh
> @@ -133,6 +133,7 @@ Creates initial ramdisk images for prelo
>    --mount "[DEV] [MP] [FSTYPE] [FSOPTS]"
>                          Mount device [DEV] on mountpoint [MP] with filesystem
>                          [FSTYPE] and options [FSOPTS] in the initramfs
> +  --device "[DEV]"      Bring up [DEV] in initramfs
>    -i, --include [SOURCE] [TARGET]
>                          Include the files in the SOURCE directory into the
>                           Target directory in the final initramfs.
> @@ -261,6 +262,7 @@ TEMP=$(unset POSIXLY_CORRECT; getopt \
>      --long fscks: \
>      --long add-fstab: \
>      --long mount: \
> +    --long device: \
>      --long nofscks: \
>      --long ro-mnt \
>      --long kmoddir: \
> @@ -327,6 +329,7 @@ while :; do
>          --fscks)       push fscks_l              "$2"; shift;;
>          --add-fstab)   push add_fstab_l          "$2"; shift;;
>          --mount)       push fstab_lines          "$2"; shift;;
> +        --device)      push host_devs            "$2"; shift;;
>          --nofscks)     nofscks_l="yes";;
>          --ro-mnt)      ro_mnt_l="yes";;
>          -k|--kmoddir)  drivers_dir_l="$2"; shift;;
> --- dracut.orig/dracut.8.asc
> +++ dracut/dracut.8.asc
> @@ -321,6 +321,9 @@ provide a valid _/etc/fstab_.
>      Mount _<device>_ on _<mountpoint>_ with _<filesystem type>_ and _<filesystem
>      options>_ in the initramfs
>  
> +**--device** _<device>_ ::
> +    Bring up _<device>_ in initramfs, _<device>_ should be the device name
> +
>  **-i, --include** _<SOURCE>_ _<TARGET>_::
>      include the files in the SOURCE directory into the
>      TARGET directory in the final initramfs. If SOURCE is a file, it will be