From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] pxa25x: Add UDC registers definitions
Date: Sat, 18 Aug 2012 01:24:22 +0200 [thread overview]
Message-ID: <201208180124.22222.marex@denx.de> (raw)
In-Reply-To: <502EBB46.6090307@gmail.com>
Dear ?ukasz Da?ek,
[...]
> > You don't need this.
>
> Why? GCC on ARM doesn't align structures?
Align to what ? 4 bytes in uboot, so no need for __packed.
> >> +#define UDCCFR_AREN (1<< 7) /* ACK response enable (now) */
> >> +#define UDCCFR_ACM (1<< 2) /* ACK control mode (wait for
AREN) */
> >> +/* latest pxa255 errata define new "must be one" bits in UDCCFR */
> >> +#define UDCCFR_MB1 (0xff& ~(UDCCFR_AREN | UDCCFR_ACM))
> >
> > What errata and where? Please document it in the comment. Also, is the
> > register only 8 bit wide?
>
> Ok, I will document. All registers are 32 bits wide. But some you have to
> access like they are 8 bits wide.
Ouch :-(
> ?ukasz Da?ek
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-17 23:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:31 [U-Boot] [PATCH 1/3] usbether: Fixed bug when using with PXA25X chips Łukasz Dałek
2012-08-17 20:31 ` [U-Boot] [PATCH 2/3] pxa25x: Add UDC registers definitions Łukasz Dałek
2012-08-17 20:50 ` Marek Vasut
2012-08-17 21:44 ` Łukasz Dałek
2012-08-17 23:24 ` Marek Vasut [this message]
2012-08-17 20:31 ` [U-Boot] [PATCH 3/3] pxa25x: Add USB ethernet gadget driver Łukasz Dałek
2012-08-17 20:57 ` Marek Vasut
2012-08-17 21:39 ` Łukasz Dałek
2012-08-17 23:25 ` Marek Vasut
2012-08-17 20:48 ` [U-Boot] [PATCH 1/3] usbether: Fixed bug when using with PXA25X chips Marek Vasut
2012-08-17 22:07 ` Łukasz Dałek
2012-08-17 23:32 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208180124.22222.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.