From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef'
Date: Sun, 19 Aug 2012 01:43:22 +0200 [thread overview]
Message-ID: <201208190143.22738.marex@denx.de> (raw)
In-Reply-To: <1345332492-3273-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to undef an option that is not enabled by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx28evk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
> #define CONFIG_SF_DEFAULT_SPEED 24000000
>
> /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
> #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
> #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-18 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 23:28 [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Fabio Estevam
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
2012-08-18 23:43 ` Marek Vasut
2012-08-19 13:46 ` Otavio Salvador
2012-08-19 15:33 ` Fabio Estevam
2012-08-19 15:36 ` Fabio Estevam
2012-08-19 15:39 ` Otavio Salvador
2012-08-20 8:02 ` Stefano Babic
2012-08-18 23:43 ` Marek Vasut [this message]
2012-08-19 8:41 ` [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Stefano Babic
2012-08-20 8:02 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208190143.22738.marex@denx.de \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.