From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316Ab2HSGN5 (ORCPT ); Sun, 19 Aug 2012 02:13:57 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35231 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302Ab2HSGNz (ORCPT ); Sun, 19 Aug 2012 02:13:55 -0400 X-Sasl-enc: RfuLY3ThL1M/n7xQI9ItsFQOs7euW2LVxs5ocnt/2a2W 1345356834 Date: Sat, 18 Aug 2012 23:13:52 -0700 From: Greg KH To: Jim Cromie Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, Markus Trippelsdorf Subject: Re: [PATCH] dyndbg: fix for SOH in logging messages Message-ID: <20120819061352.GA1971@kroah.com> References: <1345336551-10066-1-git-send-email-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345336551-10066-1-git-send-email-jim.cromie@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 18, 2012 at 06:35:51PM -0600, Jim Cromie wrote: > commit af7f2158fde was done against master, and clashed with structured logging's change of KERN_LEVEL to SOH. > > Bisected and fixed by Markus Trippelsdorf. > > CC: Markus Trippelsdorf > Signed-off-by: Jim Cromie > --- > drivers/base/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index cdd01c5..5e6e00b 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -1912,8 +1912,8 @@ int __dev_printk(const char *level, const struct device *dev, > "DEVICE=+%s:%s", subsys, dev_name(dev)); > } > skip: > - if (level[3]) > - level_extra = &level[3]; /* skip past "" */ > + if (level[2]) > + level_extra = &level[2]; /* skip past KERN_SOH "L" */ > > return printk_emit(0, level[1] - '0', > dictlen ? dict : NULL, dictlen, No, this still doesn't resolve the issue for me, it still looks like it did before this patch (exactly the same to be exact.) I do seem to get the correct output if I revert your original patch (af7f2158fde), should I just do that instead? greg k-h