From: Thierry Reding <thierry.reding@avionic-design.de>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Bryan Wu <bryan.wu@canonical.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions
Date: Mon, 20 Aug 2012 07:06:47 +0200 [thread overview]
Message-ID: <20120820050647.GB16729@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF0095@DQHE02.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
On Mon, Aug 20, 2012 at 04:02:05AM +0000, Kim, Milo wrote:
[...]
> diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
[...]
> @@ -111,6 +114,8 @@ struct lm3530_data {
> struct regulator *regulator;
> enum led_brightness brightness;
> bool enable;
> + struct pwm_device *pwm;
> + int period_ns;
I forgot: maybe this should be an "unsigned int"?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-20 5:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 4:02 [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions Kim, Milo
2012-08-20 5:04 ` Thierry Reding
2012-08-20 5:06 ` Thierry Reding [this message]
2012-08-20 5:37 ` Arnd Bergmann
2012-08-20 5:58 ` Thierry Reding
2012-08-20 6:16 ` Kim, Milo
2012-08-20 7:31 ` Thierry Reding
2012-08-20 7:41 ` Kim, Milo
2012-08-20 7:50 ` Thierry Reding
2012-08-20 7:56 ` Kim, Milo
2012-08-20 6:13 ` Kim, Milo
2012-08-20 6:45 ` Arnd Bergmann
2012-08-20 7:26 ` Kim, Milo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820050647.GB16729@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=Milo.Kim@ti.com \
--cc=arnd@arndb.de \
--cc=bryan.wu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.