From: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 06/10] drm/nouveau: sparse fixes
Date: Mon, 20 Aug 2012 16:29:49 +1000 [thread overview]
Message-ID: <20120820062949.GC2013@nisroch.redhat.com> (raw)
In-Reply-To: <1345410004-27729-6-git-send-email-marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Sun, Aug 19, 2012 at 11:00:01PM +0200, Marcin Slusarz wrote:
> drivers/gpu/drm/nouveau/core/core/object.c:452:22: warning: non-ANSI function declaration of function 'nouveau_object_debug'
>
> drivers/gpu/drm/nouveau/core/subdev/device/base.c:64:10: warning: Initializer entry defined twice
> drivers/gpu/drm/nouveau/core/subdev/device/base.c:73:10: also defined here
Applied the first hunk, the second I'd already fixed in my tree.
>
> (harmless, second init had the same value)
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/gpu/drm/nouveau/core/core/object.c | 2 +-
> drivers/gpu/drm/nouveau/core/subdev/device/base.c | 1 -
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/core/object.c b/drivers/gpu/drm/nouveau/core/core/object.c
> index d94cb66..0daab62 100644
> --- a/drivers/gpu/drm/nouveau/core/core/object.c
> +++ b/drivers/gpu/drm/nouveau/core/core/object.c
> @@ -449,7 +449,7 @@ nouveau_object_dec(struct nouveau_object *object, bool suspend)
> }
>
> void
> -nouveau_object_debug()
> +nouveau_object_debug(void)
> {
> #ifdef NOUVEAU_OBJECT_MAGIC
> struct nouveau_object *object;
> diff --git a/drivers/gpu/drm/nouveau/core/subdev/device/base.c b/drivers/gpu/drm/nouveau/core/subdev/device/base.c
> index d4abca7..afc6be0 100644
> --- a/drivers/gpu/drm/nouveau/core/subdev/device/base.c
> +++ b/drivers/gpu/drm/nouveau/core/subdev/device/base.c
> @@ -70,7 +70,6 @@ static const u64 disable_map[] = {
> [NVDEV_SUBDEV_VM] = NV_DEVICE_DISABLE_CORE,
> [NVDEV_SUBDEV_INSTMEM] = NV_DEVICE_DISABLE_CORE,
> [NVDEV_SUBDEV_BAR] = NV_DEVICE_DISABLE_CORE,
> - [NVDEV_SUBDEV_GPIO] = NV_DEVICE_DISABLE_CORE,
> [NVDEV_SUBDEV_VOLT] = NV_DEVICE_DISABLE_CORE,
> [NVDEV_SUBDEV_FAN0] = NV_DEVICE_DISABLE_CORE,
> [NVDEV_SUBDEV_CLOCK] = NV_DEVICE_DISABLE_CORE,
> --
> 1.7.8.6
>
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
prev parent reply other threads:[~2012-08-20 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 21:00 [PATCH 06/10] drm/nouveau: sparse fixes Marcin Slusarz
[not found] ` <1345410004-27729-6-git-send-email-marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-08-20 6:29 ` Ben Skeggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820062949.GC2013@nisroch.redhat.com \
--to=skeggsb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.