From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 20 Aug 2012 09:16:59 +0200 (CEST) Received: from moutng.kundenserver.de ([212.227.126.187]:55179 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1901346Ab2HTHQv (ORCPT ); Mon, 20 Aug 2012 09:16:51 +0200 Received: from mailbox.adnet.avionic-design.de (mailbox.avionic-design.de [109.75.18.3]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MOELI-1T04Qy1g1s-005VIN; Mon, 20 Aug 2012 09:16:44 +0200 Received: from localhost (localhost [127.0.0.1]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id E237D2A2830D; Mon, 20 Aug 2012 09:16:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at avionic-design.de Received: from mailbox.adnet.avionic-design.de ([127.0.0.1]) by localhost (mailbox.avionic-design.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGP3gbwBCNsG; Mon, 20 Aug 2012 09:16:42 +0200 (CEST) Received: from localhost (avionic-0098.adnet.avionic-design.de [172.20.31.233]) (Authenticated sender: thierry.reding) by mailbox.adnet.avionic-design.de (Postfix) with ESMTPA id 8B4502A28054; Mon, 20 Aug 2012 09:16:42 +0200 (CEST) Date: Mon, 20 Aug 2012 09:16:41 +0200 From: Thierry Reding To: Greg KH Cc: Bjorn Helgaas , David Daney , Ralf Baechle , linux-pci@vger.kernel.org, linux-mips Subject: Re: PCI Section mismatch error in linux-next. Message-ID: <20120820071641.GA4083@avionic-0098.mockup.avionic-design.de> References: <20120817182931.GA27391@avionic-0098.adnet.avionic-design.de> <20120817200755.GA16021@avionic-0098.adnet.avionic-design.de> <20120817204839.GA2017@avionic-0098.mockup.avionic-design.de> <20120817210718.GA14842@avionic-0098.mockup.avionic-design.de> <20120817213247.GA1056@avionic-0098.mockup.avionic-design.de> <20120820053036.GA23166@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20120820053036.GA23166@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:7jZBYVuukQ5S/EoDayJZlxQGbMk47r55JOdL0IMO7io n4ToWzgV6AtX5IQs/8nCMKBpe80+Fu8MOsEZMAFU/6T/nwfoJe 3BwzJrAQvgFd9szw9zDRW2gshkXuFPSkwXVmKV9x+aYrTrriwh +6VJyNfnr0lfy5BcXjt6E9w4FtJuPcn/m76i1fb+PhNVUwLkX+ qlUaUAYuN44SiAZzvuX0974p1y3QgVoLBwV7v2AxYULy3AjWpW DFIyHY0jfjykCVbioURMrzAMagNryFlipRMzxxzMRzhOXzn+OX 509uHgFdRkLgfJLOkndOp6Qp0Ob0J/aayiX6crddrW9SodVNxe tRrRAD4gEfDLx0RhgczoUB9LzmacxILvlAQ0hvTOSS8eZ6smi4 TV8hlizSb1YLEeuq66+vHkeGZffep9AO1Y= X-archive-position: 34284 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: thierry.reding@avionic-design.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 19, 2012 at 10:30:36PM -0700, Greg KH wrote: > On Fri, Aug 17, 2012 at 11:32:47PM +0200, Thierry Reding wrote: > > On Fri, Aug 17, 2012 at 03:25:22PM -0600, Bjorn Helgaas wrote: > > > On Fri, Aug 17, 2012 at 3:07 PM, Thierry Reding > > > wrote: > > > > On Fri, Aug 17, 2012 at 10:48:39PM +0200, Thierry Reding wrote: > > > >> On Fri, Aug 17, 2012 at 02:39:34PM -0600, Bjorn Helgaas wrote: > > > > [...] > > > >> > Well, maybe you just need to turn on CONFIG_HOTPLUG. How would = that > > > >> > affect you? I think we would still have to change some __inits = to > > > >> > __devinit, including pcibios_update_irq(), but it might be more > > > >> > manageable. > > > >> > > > >> You said that depending on HOTPLUG wouldn't be enough because it w= ould > > > >> exclude reenumeration at runtime if HOTPLUG wasn't defined. Also i= t is > > > >> theoretically possible to build a kernel without HOTPLUG but have = the > > > >> enumeration start after init because of deferred probing. Those ca= ses > > > >> won't work if we keep __init or __devinit respectively, right? > > > > > > > > Another possibility would be to make PCI select HOTPLUG or depend o= n it. > > > > That way it would be made sure that __devinit wouldn't cause all the > > > > functions to be discarded after init. > > >=20 > > > There's been some discussion recently about whether CONFIG_HOTPLUG is > > > worth keeping any more, but nothing's been resolved yet. If we did > > > decide to remove CONFIG_HOTPLUG, or require it for PCI, I would rather > > > just remove all the __devinit annotations because they'd be > > > superfluous. > >=20 > > I've missed that discussion. Can you point me to it? >=20 > It's pretty much just me saying the whole thing is a mess, causes > problems, and really doesn't solve any memory usage issues. Ideally we > should just: > - remove CONFIG_HOTPLUG and assume it is enabled > - because of that, we can delete the large majority of the > __dev* markings >=20 > The memory savings these days are so tiny, if at all, and everyone, > including me, gets it wrong all the time. >=20 > As we pretty much allow anything to be disabled/enabled at any point in > time after boot, we are all running systems that rely on CONFIG_HOTPLUG > anyway. To find a static system that doesn't need it is quite rare from > what I have found. I've been reading through the thread it seems like the consensus is to just drop it. Though there seems to be lacking a formal decision. Thierry --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQMeRZAAoJEN0jrNd/PrOhpR4P/A3x3bRrhHIXloLCiFItBcT4 lYrtqz9XIg28IjUtDvdKeoppngU9LW9Lc58nzkJY+TMyCXOh5vGCPphk1wuCV6mP rs87YwSkfL7PCunHGcEI5WHTpFkkbGr8x4iwbltRCLOHWOwge1L0Xl0foUX0lhKW wDo5OpyEAar0z9JWDX2olGfb9TZz9ALTEwKhxGqM6XTQcJZo4UPc5MmFQUUk4Qs6 FU9hk6Dz8qWA/EYTRRqGqtuindEsrWn5JixVYYQ3lhwPvavHVVXE7DP8/Dm+GtBo fpticf4E4+pPHqxzV+38yL0l+pNxv72WAYfPwZBfZEEXvnnn6TXvf6uqHFOubaDS wtf+Cw8XlVFzcScmhdprIpRIaoPayWOaCPnPibP9WcrOBGSIy2T5mRTefQeJ0dTJ u/P2TPDoOTQWEAIS1eMmKka/HLmIf6jc712IGq5MnVWd00Xg0jMNRoJTbgTUzFNc uQZofe/JB+eD4VDtMkLEy/b8aN5AjS7JxoJmpjzeT4ujazpTCe+AdvP00ZePXCkb GMBaiif2yvdG6MjBehI1Z/GDTfozht0D33EmqYq9Dv2aNNEk+OgaWh9tLhPySwtm 8rql8uD74sIP97qs1OBzLWTdscDSTyLG1fk9xGnJuKx5T+3VeywYCUXIH+HzRgyT zWWEBgWRwO7oBrtDgGsA =P4Dy -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--