Re: linux 3.6-rc2, undefined reference to omap_musb_mailbox

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]

On Mon, Aug 20, 2012 at 04:37:28PM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi,
> 
> On Mon, Aug 20, 2012 at 3:56 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Mon, Aug 20, 2012 at 03:46:07PM +0530, ABRAHAM, KISHON VIJAY wrote:
> >> Hi,
> >>
> >> On Mon, Aug 20, 2012 at 3:24 PM, Felipe Balbi <balbi@ti.com> wrote:
> >> > On Mon, Aug 20, 2012 at 11:06:34AM +0530, ABRAHAM, KISHON VIJAY wrote:
> >> >> Hi,
> >> >>
> >> >> On Sat, Aug 18, 2012 at 9:34 PM, Peter Meerwald <pmeerw@pmeerw.net> wrote:
> >> >> >
> >> >> > 3.6-rc2 fails to compile with
> >> >> > CONFIG_USB_MUSB_HDRC=m
> >> >> > CONFIG_USB_MUSB_OMAP2PLUS=m
> >> >> >
> >> >> >   LD      init/built-in.o
> >> >> > drivers/built-in.o: In function `twl4030_usb_irq':
> >> >> > /home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:518: undefined reference to `omap_musb_mailbox'
> >> >> > drivers/built-in.o: In function `twl4030_usb_phy_init':
> >> >> > /home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:540: undefined reference to `omap_musb_mailbox'
> >> >>
> >> >> Having TWL4030_USB as a module will get rid of this.
> >> >> I'll see how this can be resolved when some modules are *built-in* and
> >> >> some are made as *modules*.
> >> >
> >> > EXPORT_SYMBOL_GPL() should sort that out, right ?
> >>
> >> No :-( I already have EXPORT_SYMBOL_GPL() in omap2430.c.
> >
> > I see you're missing an "extern" on the function prototype (on the
> > header). Not sure how modules.dep is generated, but maybe it needs the
> > "extern" there. Can you check it out ?
> 
> That isn't helping either.

oh, ok... twl4030-usb is built-in... now that makes sense. Since
twl4030-usb uses a symbol from omap2430, then it should depend on it,
otherwise this will always happen.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]