From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] netfilter: nfnetlink_log: fix NLA_PUT macro removal bug
Date: Mon, 20 Aug 2012 16:52:06 +0200 [thread overview]
Message-ID: <20120820145206.GB18676@1984> (raw)
In-Reply-To: <1345407370-30009-2-git-send-email-kaber@trash.net>
On Sun, Aug 19, 2012 at 10:16:08PM +0200, Patrick McHardy wrote:
> Commit 1db20a52 (nfnetlink_log: Stop using NLA_PUT*().) incorrectly
> converted a NLA_PUT_BE16 macro to nla_put_be32() in nfnetlink_log:
>
> - NLA_PUT_BE16(inst->skb, NFULA_HWTYPE, htons(skb->dev->type));
> + if (nla_put_be32(inst->skb, NFULA_HWTYPE, htons(skb->dev->type))
queued for net tree. Thanks Patrick.
next prev parent reply other threads:[~2012-08-20 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 20:16 [PATCH 0/3]: netfilter fixes Patrick McHardy
2012-08-19 20:16 ` [PATCH 1/3] netfilter: nfnetlink_log: fix NLA_PUT macro removal bug Patrick McHardy
2012-08-20 14:52 ` Pablo Neira Ayuso [this message]
2012-08-19 20:16 ` [PATCH 2/3] netfilter: sparse endian fixes Patrick McHardy
2012-08-20 14:53 ` Pablo Neira Ayuso
2012-08-19 20:16 ` [PATCH 3/3] netfilter: nf_conntrack: remove unnecessary RTNL locking Patrick McHardy
2012-08-20 14:53 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820145206.GB18676@1984 \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.