From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seth Forshee Subject: Re: [RFC PATCH 7/7] drm/pci: Defer initialization of secondary graphics devices until switcheroo is ready Date: Mon, 20 Aug 2012 10:56:33 -0500 Message-ID: <20120820155633.GF11013@thinkpad-t410> References: <20120806045150.GA23652@thinkpad-t410> <1345476664-22066-1-git-send-email-seth.forshee@canonical.com> <1345476664-22066-8-git-send-email-seth.forshee@canonical.com> <20120820153640.GA29614@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120820153640.GA29614@srcf.ucam.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Garrett Cc: Dave Airlie , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andreas Heider List-Id: dri-devel@lists.freedesktop.org On Mon, Aug 20, 2012 at 04:36:40PM +0100, Matthew Garrett wrote: > On Mon, Aug 20, 2012 at 10:31:04AM -0500, Seth Forshee wrote: > > + /* > > + * For secondary graphics devices shouldn't be initialized > > + * until the handler and primary graphics device have been > > + * registered with vga_switcheroo. > > + * > > + * FIXME: Is vga_default_device() reliable enough for this > > + * purpose? > > + * > > + * FIXME: If vga_switcheroo is disabled secondary devices > > + * never gets initialized. Is this okay? Maybe it is, since > > + * we can't switch to the secondary GPU anyway. > > + */ > > Won't this break the multiple cards with independent outputs case? Yes, if they don't have a switcheroo handler. I only have experience with one such machine, which had optimus graphics. My recollection is that it did have a switcheroo handler, which was only capable of controlling power to the discrete card.