All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: desi babu <vdesibabu@yahoo.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze
Date: Mon, 20 Aug 2012 14:34:34 -0500	[thread overview]
Message-ID: <20120820193434.GN16157@illuin> (raw)
In-Reply-To: <20120820105429.5766948f@doriath.home>

On Mon, Aug 20, 2012 at 10:54:29AM -0300, Luiz Capitulino wrote:
> On Fri, 17 Aug 2012 10:11:29 -0700 (PDT)
> desi babu <vdesibabu@yahoo.com> wrote:
> 
> > Guest-Agent : Windows 2008 Error : Relase 1.1.90
> > 
> > error : internal error unable to execute QEMU command 'guest-fsfreeze-freeze': this feature or command is not currently supported.
> 
> That's correct, fsfreze is not supported on Windows.
> 
> > Guest-info shows the command is available.  Is there any information available on the list of commands supported inside Windows ? Appreciate if you have any pointers.
> 
> That's a qemu-ga bug. CC'ing Michael to check if he has a fix in mind for this.
> 

I've been thinking about this one for a while. It's considered expected
behavior, but I realize it sucks for discoverability. I doubt we want to
do platform-specific QAPI schema definitions, so the only option I can
think of is some kind of [de-]registration mechanism where we can mark
commands as being not available for a particular build/platform in the
cases where we stub out command implementations.

I think we can expose this to existing clients by no longer listing commands
marked as unsupported in the list provided by the guest-info command. It
should "just work". Can probably do it for 1.3. For now, clients will
have to catch it in the error-handling path.

  reply	other threads:[~2012-08-20 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 17:11 [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze desi babu
2012-08-20 13:54 ` Luiz Capitulino
2012-08-20 19:34   ` Michael Roth [this message]
2012-08-21 12:58     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120820193434.GN16157@illuin \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vdesibabu@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.