From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
balbi@ti.com, ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: bcm63xx UDC driver
Date: Mon, 20 Aug 2012 21:52:31 +0200 [thread overview]
Message-ID: <20120820195231.GA7087@breakpoint.cc> (raw)
In-Reply-To: <CAJiQ=7CADk_75U5=OQH8vXA=xtj-U=TbBhXzC8JfUGbYEKmxng@mail.gmail.com>
On Sun, Aug 19, 2012 at 01:53:26PM -0700, Kevin Cernekee wrote:
> > According to this code, i in iudma[] can be in 1..5. You could have more than
> > one IRQ. The comment above this for loop is point less. So I think if you can
> > only have _one_ idma irq than you could remove the for loop in
> > bcm63xx_udc_data_isr().
>
> There are 6 IUDMA channels, and each one always has a dedicated
> interrupt line. IRQ resource #0 is the control (vbus/speed/cfg/etc.)
> IRQ, and IRQ resources #1-6 are the IUDMA (IN/OUT data) IRQs. Maybe
> it would be good to add a longer comment to clarify this?
Now that I look at the code again, I see what I've missed. So you can have
multiple irqs in the range #1-6. Why not pass the iudma struct then?
Passing the struct instead of a range is good thing.
Sebastian
next prev parent reply other threads:[~2012-08-20 19:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 17:18 [PATCH] usb: gadget: bcm63xx UDC driver Kevin Cernekee
2012-08-19 20:17 ` Sebastian Andrzej Siewior
2012-08-19 20:53 ` Kevin Cernekee
2012-08-20 7:24 ` Felipe Balbi
2012-08-20 19:52 ` Sebastian Andrzej Siewior [this message]
2012-08-20 7:40 ` Felipe Balbi
2012-08-21 3:48 ` Kevin Cernekee
2012-08-21 12:04 ` Felipe Balbi
2012-08-21 15:20 ` Kevin Cernekee
2012-08-21 18:08 ` Felipe Balbi
2012-08-21 19:35 ` Kevin Cernekee
2012-08-21 20:34 ` Alan Stern
2012-08-21 20:34 ` Alan Stern
2012-08-21 21:08 ` Kevin Cernekee
2012-08-21 21:34 ` Alan Stern
2012-08-21 21:34 ` Alan Stern
2012-08-21 21:58 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820195231.GA7087@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=balbi@ti.com \
--cc=cernekee@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.